diff mbox series

[v1] drivers/acpi/x86: check return null pointer from acpi_evaluate_dsm()

Message ID 20220828205120.1956222-1-floridsleeves@gmail.com
State New
Headers show
Series [v1] drivers/acpi/x86: check return null pointer from acpi_evaluate_dsm() | expand

Commit Message

Li Zhong Aug. 28, 2022, 8:51 p.m. UTC 
From: lily <floridsleeves@gmail.com>

Check return value from acpi_evaluate_dsm(). Only do ACPI_FREE() when
out_obj is not NULL pointers.

Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
 drivers/acpi/x86/s2idle.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Mika Westerberg Aug. 29, 2022, 5:13 a.m. UTC | #1 
Hi,

On Sun, Aug 28, 2022 at 01:51:20PM -0700, Li Zhong wrote:
> From: lily <floridsleeves@gmail.com>
> 
> Check return value from acpi_evaluate_dsm(). Only do ACPI_FREE() when
> out_obj is not NULL pointers.

ACPI_FREE() expands to kfree() and that allows NULL pointers so I don't
think this patch is necessary.
diff mbox series

Patch

diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
index f9ac12b778e6..1b449d3cfbf7 100644
--- a/drivers/acpi/x86/s2idle.c
+++ b/drivers/acpi/x86/s2idle.c
@@ -328,7 +328,8 @@  static void acpi_sleep_run_lps0_dsm(unsigned int func, unsigned int func_mask, g
 
 	out_obj = acpi_evaluate_dsm(lps0_device_handle, &dsm_guid,
 					rev_id, func, NULL);
-	ACPI_FREE(out_obj);
+	if (!out_obj)
+		ACPI_FREE(out_obj);
 
 	acpi_handle_debug(lps0_device_handle, "_DSM function %u evaluation %s\n",
 			  func, out_obj ? "successful" : "failed");