| Message ID | 20220822041025.3221406-1-weiyongjun1@huawei.com |
|---|---|
| State | Accepted |
| Commit | 303e6da99429510b1e4edf833afe90ac8542e747 |
| Headers | show |
| Series | [v2] gpio: mockup: remove gpio debugfs when remove device | expand |
On Mon, Aug 22, 2022 at 5:52 AM Wei Yongjun <weiyongjun1@huawei.com> wrote: > > GPIO mockup debugfs is created in gpio_mockup_probe() but > forgot to remove when remove device. This patch add a devm > managed callback for removing them. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > v1 -> v2: return from devm_add_xx directly as Bartosz's suggestion Applied, thanks! Bart
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index 8943cea92764..a2e505a7545c 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -373,6 +373,13 @@ static void gpio_mockup_debugfs_setup(struct device *dev, } } +static void gpio_mockup_debugfs_cleanup(void *data) +{ + struct gpio_mockup_chip *chip = data; + + debugfs_remove_recursive(chip->dbg_dir); +} + static void gpio_mockup_dispose_mappings(void *data) { struct gpio_mockup_chip *chip = data; @@ -455,7 +462,7 @@ static int gpio_mockup_probe(struct platform_device *pdev) gpio_mockup_debugfs_setup(dev, chip); - return 0; + return devm_add_action_or_reset(dev, gpio_mockup_debugfs_cleanup, chip); } static const struct of_device_id gpio_mockup_of_match[] = {
GPIO mockup debugfs is created in gpio_mockup_probe() but forgot to remove when remove device. This patch add a devm managed callback for removing them. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- v1 -> v2: return from devm_add_xx directly as Bartosz's suggestion --- drivers/gpio/gpio-mockup.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)