| Message ID | 20220822184239.169757-3-pierre-louis.bossart@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 43265ceeb0b9cb1f8f5fb182adaa6c2ed4941478 |
| Headers | show |
| Series | ASoC: codecs: minor cppcheck cleanups | expand |
diff --git a/sound/soc/codecs/wcd-mbhc-v2.c b/sound/soc/codecs/wcd-mbhc-v2.c index 98baef594bf31..b16a18dbfe7af 100644 --- a/sound/soc/codecs/wcd-mbhc-v2.c +++ b/sound/soc/codecs/wcd-mbhc-v2.c @@ -1189,7 +1189,7 @@ static void wcd_correct_swch_plug(struct work_struct *work) pt_gnd_mic_swap_cnt = 0; plug_type = wcd_mbhc_get_plug_from_adc(mbhc, output_mv); continue; - } else if (cross_conn < 0) /* Error */ + } else /* Error if (cross_conn < 0) */ continue; if (pt_gnd_mic_swap_cnt == GND_MIC_SWAP_THRESHOLD) {
cppcheck warning: sound/soc/codecs/wcd-mbhc-v2.c:1192:26: style: Condition 'cross_conn<0' is always true [knownConditionTrueFalse] } else if (cross_conn < 0) /* Error */ ^ sound/soc/codecs/wcd-mbhc-v2.c:1188:15: note: Assuming that condition '!cross_conn' is not redundant } else if (!cross_conn) { /* no cross connection */ ^ sound/soc/codecs/wcd-mbhc-v2.c:1192:26: note: Condition 'cross_conn<0' is always true } else if (cross_conn < 0) /* Error */ ^ Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> Reviewed-by: Chao Song <chao.song@intel.com> --- sound/soc/codecs/wcd-mbhc-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)