| Message ID | 1324893613-5469-4-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Dec 26, 2011 at 03:30:12PM +0530, Sachin Kamat wrote: > This patch adds support for FIMC 0, 1 and 2 on SMDKV210 board. Why does this not also apply to the Aquilla, Gony and Torbreck machines? > &s3c_device_wdt, > + &s5p_device_fimc0, > + &s5p_device_fimc1, > + &s5p_device_fimc2, > &s5p_device_mfc, The support consists solely of adding them to the lists of devices, there's no visible per board hookup here.
Hi Mark, Thank you for your review comments. On 26 December 2011 17:24, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Mon, Dec 26, 2011 at 03:30:12PM +0530, Sachin Kamat wrote: >> This patch adds support for FIMC 0, 1 and 2 on SMDKV210 board. > > Why does this not also apply to the Aquilla, Gony and Torbreck machines? FIMC is already enabled in Aquila and Goni machines. I was not sure if it is required in Torbreck. > >> &s3c_device_wdt, >> + &s5p_device_fimc0, >> + &s5p_device_fimc1, >> + &s5p_device_fimc2, >> &s5p_device_mfc, > > The support consists solely of adding them to the lists of devices, > there's no visible per board hookup here. Yes. > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sachin, thanks for the patch. On 12/26/2011 11:00 AM, Sachin Kamat wrote: > This patch adds support for FIMC 0, 1 and 2 on SMDKV210 board. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > arch/arm/mach-s5pv210/Kconfig | 3 +++ > arch/arm/mach-s5pv210/mach-smdkv210.c | 3 +++ > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig > index 32893c7..66e1b3d 100644 > --- a/arch/arm/mach-s5pv210/Kconfig > +++ b/arch/arm/mach-s5pv210/Kconfig > @@ -138,6 +138,9 @@ config MACH_SMDKV210 > select S3C_DEV_I2C2 > select S3C_DEV_RTC > select S3C_DEV_WDT > + select S5P_DEV_FIMC0 > + select S5P_DEV_FIMC1 > + select S5P_DEV_FIMC2 > select S5P_DEV_MFC > select SAMSUNG_DEV_ADC > select SAMSUNG_DEV_BACKLIGHT > diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210.c > index d50cacd..038fc5f 100644 > --- a/arch/arm/mach-s5pv210/mach-smdkv210.c > +++ b/arch/arm/mach-s5pv210/mach-smdkv210.c > @@ -226,6 +226,9 @@ static struct platform_device *smdkv210_devices[] __initdata = { > &s3c_device_rtc, > &s3c_device_ts, > &s3c_device_wdt, > + &s5p_device_fimc0, > + &s5p_device_fimc1, > + &s5p_device_fimc2, Sorry, this won't work, unless you add &s5p_device_fimc_md after all s5p_fimc_device? entries. s5p_device_fimc_md is a platform device for FIMC media device driver (/dev/media?), which registers all required video nodes (mem-to-mem and video capture). Complete board code for FIMC can be found in Goni (or Nuri) board files. Does the above really work for you with 3.2-rc7 kernel ? I've had prepared a patch adding s5p_device_fimc_md for the SMDK boards that already register FIMC devices, but got distracted by other tasks and finally I didn't send it for 3.2 :( BTW, is there anyone interested in s3c64xx (s3c24xx) CAMIF v4l2 driver in the mainline kernel ? I've started some works on it and could carry on with that if there is some interest, so we can have something which is in line with the mainline APIs. -- Thanks, Sylwester
Hi Sylwester, Thank you for your comments. I did check Goni code and found that there was s5p_device_fimc_md device added. But I could n't find much description about it and also initial version did not have it enabled, hence I did not include it. I will re-submit the patch after adding s5p_device_fimc_md in the device list. Thanks and regards Sachin On 26 December 2011 21:57, Sylwester Nawrocki <snjw23@gmail.com> wrote: > Hi Sachin, > > thanks for the patch. > > On 12/26/2011 11:00 AM, Sachin Kamat wrote: >> This patch adds support for FIMC 0, 1 and 2 on SMDKV210 board. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> arch/arm/mach-s5pv210/Kconfig | 3 +++ >> arch/arm/mach-s5pv210/mach-smdkv210.c | 3 +++ >> 2 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig >> index 32893c7..66e1b3d 100644 >> --- a/arch/arm/mach-s5pv210/Kconfig >> +++ b/arch/arm/mach-s5pv210/Kconfig >> @@ -138,6 +138,9 @@ config MACH_SMDKV210 >> select S3C_DEV_I2C2 >> select S3C_DEV_RTC >> select S3C_DEV_WDT >> + select S5P_DEV_FIMC0 >> + select S5P_DEV_FIMC1 >> + select S5P_DEV_FIMC2 >> select S5P_DEV_MFC >> select SAMSUNG_DEV_ADC >> select SAMSUNG_DEV_BACKLIGHT >> diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210.c >> index d50cacd..038fc5f 100644 >> --- a/arch/arm/mach-s5pv210/mach-smdkv210.c >> +++ b/arch/arm/mach-s5pv210/mach-smdkv210.c >> @@ -226,6 +226,9 @@ static struct platform_device *smdkv210_devices[] __initdata = { >> &s3c_device_rtc, >> &s3c_device_ts, >> &s3c_device_wdt, >> + &s5p_device_fimc0, >> + &s5p_device_fimc1, >> + &s5p_device_fimc2, > > Sorry, this won't work, unless you add &s5p_device_fimc_md after all > s5p_fimc_device? entries. s5p_device_fimc_md is a platform device for > FIMC media device driver (/dev/media?), which registers all required > video nodes (mem-to-mem and video capture). > Complete board code for FIMC can be found in Goni (or Nuri) board files. > > Does the above really work for you with 3.2-rc7 kernel ? > > I've had prepared a patch adding s5p_device_fimc_md for the SMDK boards > that already register FIMC devices, but got distracted by other tasks > and finally I didn't send it for 3.2 :( > > BTW, is there anyone interested in s3c64xx (s3c24xx) CAMIF v4l2 driver > in the mainline kernel ? I've started some works on it and could carry on > with that if there is some interest, so we can have something which > is in line with the mainline APIs. > > -- > > Thanks, > Sylwester
diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig index 32893c7..66e1b3d 100644 --- a/arch/arm/mach-s5pv210/Kconfig +++ b/arch/arm/mach-s5pv210/Kconfig @@ -138,6 +138,9 @@ config MACH_SMDKV210 select S3C_DEV_I2C2 select S3C_DEV_RTC select S3C_DEV_WDT + select S5P_DEV_FIMC0 + select S5P_DEV_FIMC1 + select S5P_DEV_FIMC2 select S5P_DEV_MFC select SAMSUNG_DEV_ADC select SAMSUNG_DEV_BACKLIGHT diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210.c index d50cacd..038fc5f 100644 --- a/arch/arm/mach-s5pv210/mach-smdkv210.c +++ b/arch/arm/mach-s5pv210/mach-smdkv210.c @@ -226,6 +226,9 @@ static struct platform_device *smdkv210_devices[] __initdata = { &s3c_device_rtc, &s3c_device_ts, &s3c_device_wdt, + &s5p_device_fimc0, + &s5p_device_fimc1, + &s5p_device_fimc2, &s5p_device_mfc, &s5p_device_mfc_l, &s5p_device_mfc_r,
This patch adds support for FIMC 0, 1 and 2 on SMDKV210 board. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- arch/arm/mach-s5pv210/Kconfig | 3 +++ arch/arm/mach-s5pv210/mach-smdkv210.c | 3 +++ 2 files changed, 6 insertions(+), 0 deletions(-)