diff mbox series

dt-bindings: pinctrl: qcom,ipq6018: Fix example 'gpio-ranges' size

Message ID 20220809214556.2489822-1-robh@kernel.org
State Accepted
Commit 487ceef03895285f44ab26f6cf0c19b21b73d40d
Headers show
Series dt-bindings: pinctrl: qcom,ipq6018: Fix example 'gpio-ranges' size | expand

Commit Message

Rob Herring (Arm) Aug. 9, 2022, 9:45 p.m. UTC
'gpio-ranges' entries have a fixed size of 1 phandle plus arg 3 cells.
The qcom,ipq6018-pinctrl example is a cell short:

Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.example.dtb: pinctrl@1000000: gpio-ranges:0: [1, 0, 80] is too short
	From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/gpio/gpio.yaml

Signed-off-by: Rob Herring <robh@kernel.org>
---
Please ack and I can send to Linus before rc1.
---
 .../devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring (Arm) Aug. 25, 2022, 7:32 p.m. UTC | #1
On Mon, Aug 22, 2022 at 01:07:48PM +0200, Linus Walleij wrote:
> On Tue, Aug 9, 2022 at 11:46 PM Rob Herring <robh@kernel.org> wrote:
> 
> > 'gpio-ranges' entries have a fixed size of 1 phandle plus arg 3 cells.
> > The qcom,ipq6018-pinctrl example is a cell short:
> >
> > Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.example.dtb: pinctrl@1000000: gpio-ranges:0: [1, 0, 80] is too short
> >         From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/gpio/gpio.yaml
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Please ack and I can send to Linus before rc1.
> 
> Sorry for delay, was on vacation :/
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> I think as binding maintainer you can just submit this kind of smaller stuff
> without any subsystem consent, if you have it acked by Krzysztof, even more so.

Don't worry, I did. It is in rc1.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
index b83c7f476e19..931e5c190ead 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml
@@ -144,7 +144,7 @@  examples:
               #interrupt-cells = <2>;
               gpio-controller;
               #gpio-cells = <2>;
-              gpio-ranges = <&tlmm 0 80>;
+              gpio-ranges = <&tlmm 0 0 80>;
 
               serial3-pinmux {
                       pins = "gpio44", "gpio45";