diff mbox series

[v2,3/4] dt-bindings: thermal: Fix missing required property

Message ID 20220809085629.509116-3-daniel.lezcano@linaro.org
State Superseded
Headers show
Series [v2,1/4] thermal/of: Fix error code in of_thermal_zone_find() | expand

Commit Message

Daniel Lezcano Aug. 9, 2022, 8:56 a.m. UTC
When the thermal zone description was converted to yaml schema, the
required 'trips' property was forgotten.

The initial text bindings was describing:

"
[ ... ]

* Thermal zone nodes

The thermal zone node is the node containing all the required info
for describing a thermal zone, including its cooling device bindings. The
thermal zone node must contain, apart from its own properties, one sub-node
containing trip nodes and one sub-node containing all the zone cooling maps.

Required properties:
- polling-delay:        The maximum number of milliseconds to wait between polls
  Type: unsigned        when checking this thermal zone.
  Size: one cell

- polling-delay-passive: The maximum number of milliseconds to wait
  Type: unsigned        between polls when performing passive cooling.
  Size: one cell

- thermal-sensors:      A list of thermal sensor phandles and sensor specifier
  Type: list of         used while monitoring the thermal zone.
  phandles + sensor
  specifier

- trips:                A sub-node which is a container of only trip point nodes
  Type: sub-node        required to describe the thermal zone.

Optional property:
- cooling-maps:         A sub-node which is a container of only cooling device
  Type: sub-node        map nodes, used to describe the relation between trips
                        and cooling devices.
  [ ... ]

"

Now the schema describes:

"
    [ ... ]

    required:
      - polling-delay
      - polling-delay-passive
      - thermal-sensors

    [ ... ]
"

Add the missing 'trips' property in the required properties.

Fixed: 1202a442a31fd ("dt-bindings: thermal: Add yaml bindings for thermal zones")
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 Documentation/devicetree/bindings/thermal/thermal-zones.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring (Arm) Aug. 9, 2022, 8:27 p.m. UTC | #1
On Tue, 09 Aug 2022 10:56:28 +0200, Daniel Lezcano wrote:
> When the thermal zone description was converted to yaml schema, the
> required 'trips' property was forgotten.
> 
> The initial text bindings was describing:
> 
> "
> [ ... ]
> 
> * Thermal zone nodes
> 
> The thermal zone node is the node containing all the required info
> for describing a thermal zone, including its cooling device bindings. The
> thermal zone node must contain, apart from its own properties, one sub-node
> containing trip nodes and one sub-node containing all the zone cooling maps.
> 
> Required properties:
> - polling-delay:        The maximum number of milliseconds to wait between polls
>   Type: unsigned        when checking this thermal zone.
>   Size: one cell
> 
> - polling-delay-passive: The maximum number of milliseconds to wait
>   Type: unsigned        between polls when performing passive cooling.
>   Size: one cell
> 
> - thermal-sensors:      A list of thermal sensor phandles and sensor specifier
>   Type: list of         used while monitoring the thermal zone.
>   phandles + sensor
>   specifier
> 
> - trips:                A sub-node which is a container of only trip point nodes
>   Type: sub-node        required to describe the thermal zone.
> 
> Optional property:
> - cooling-maps:         A sub-node which is a container of only cooling device
>   Type: sub-node        map nodes, used to describe the relation between trips
>                         and cooling devices.
>   [ ... ]
> 
> "
> 
> Now the schema describes:
> 
> "
>     [ ... ]
> 
>     required:
>       - polling-delay
>       - polling-delay-passive
>       - thermal-sensors
> 
>     [ ... ]
> "
> 
> Add the missing 'trips' property in the required properties.
> 
> Fixed: 1202a442a31fd ("dt-bindings: thermal: Add yaml bindings for thermal zones")
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  Documentation/devicetree/bindings/thermal/thermal-zones.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
index 2d34f3ccb257..8d2c6d74b605 100644
--- a/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
+++ b/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
@@ -214,6 +214,7 @@  patternProperties:
       - polling-delay
       - polling-delay-passive
       - thermal-sensors
+      - trips
 
     additionalProperties: false