| Message ID | 20220804034100.121125-11-michael.christie@oracle.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: Fix internal host code use | expand |
On 8/3/22 20:41, Mike Christie wrote: > The host codes that were supposed to only be used for internal use are > now not used, so remove them. > > Signed-off-by: Mike Christie <michael.christie@oracle.com> > --- > include/scsi/scsi_status.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/scsi/scsi_status.h b/include/scsi/scsi_status.h > index 31d30cee1869..9cb85262de64 100644 > --- a/include/scsi/scsi_status.h > +++ b/include/scsi/scsi_status.h > @@ -62,12 +62,12 @@ enum scsi_host_status { > * recover the link. Transport class will > * retry or fail IO */ > DID_TRANSPORT_FAILFAST = 0x0f, /* Transport class fastfailed the io */ > - DID_TARGET_FAILURE = 0x10, /* Permanent target failure, do not retry on > - * other paths */ > - DID_NEXUS_FAILURE = 0x11, /* Permanent nexus failure, retry on other > - * paths might yield different results */ > - DID_ALLOC_FAILURE = 0x12, /* Space allocation on the device failed */ > - DID_MEDIUM_ERROR = 0x13, /* Medium error */ > + /* > + * We used to have DID_TARGET_FAILURE, DID_NEXUS_FAILURE, > + * DID_ALLOC_FAILURE and DID_MEDIUM_ERROR at 0x10 - 0x13. For compat > + * with userspace apps that parse the host byte for SG IO, we leave > + * that block of codes unused and start at 0x14 below. > + */ > DID_TRANSPORT_MARGINAL = 0x14, /* Transport marginal errors */ > }; Reviewed-by: Bart Van Assche <bvanassche@acm.org>
diff --git a/include/scsi/scsi_status.h b/include/scsi/scsi_status.h index 31d30cee1869..9cb85262de64 100644 --- a/include/scsi/scsi_status.h +++ b/include/scsi/scsi_status.h @@ -62,12 +62,12 @@ enum scsi_host_status { * recover the link. Transport class will * retry or fail IO */ DID_TRANSPORT_FAILFAST = 0x0f, /* Transport class fastfailed the io */ - DID_TARGET_FAILURE = 0x10, /* Permanent target failure, do not retry on - * other paths */ - DID_NEXUS_FAILURE = 0x11, /* Permanent nexus failure, retry on other - * paths might yield different results */ - DID_ALLOC_FAILURE = 0x12, /* Space allocation on the device failed */ - DID_MEDIUM_ERROR = 0x13, /* Medium error */ + /* + * We used to have DID_TARGET_FAILURE, DID_NEXUS_FAILURE, + * DID_ALLOC_FAILURE and DID_MEDIUM_ERROR at 0x10 - 0x13. For compat + * with userspace apps that parse the host byte for SG IO, we leave + * that block of codes unused and start at 0x14 below. + */ DID_TRANSPORT_MARGINAL = 0x14, /* Transport marginal errors */ };
The host codes that were supposed to only be used for internal use are now not used, so remove them. Signed-off-by: Mike Christie <michael.christie@oracle.com> --- include/scsi/scsi_status.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)