diff mbox series

arm64: dts: ls1028a-qds-65bb: don't use in-band autoneg for 2500base-x

Message ID 20220802135006.4184820-1-vladimir.oltean@nxp.com
State Accepted
Commit e7406f864e765c564c5cf384464faff66114f97d
Headers show
Series arm64: dts: ls1028a-qds-65bb: don't use in-band autoneg for 2500base-x | expand

Commit Message

Vladimir Oltean Aug. 2, 2022, 1:50 p.m. UTC
The Lynx PCS integrated with ENETC port 0 does not support in-band
autoneg for the 2500base-x SERDES protocol, and prints errors from its
phylink methods. Furthermore, the AQR112 card used for these boards does
not expect in-band autoneg either. So delete the extraneous property.

Fixes: e426d63e752b ("arm64: dts: ls1028a-qds: add overlays for various serdes protocols")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts | 1 -
 1 file changed, 1 deletion(-)

Comments

Shawn Guo Aug. 21, 2022, 1:32 p.m. UTC | #1
On Tue, Aug 02, 2022 at 04:50:06PM +0300, Vladimir Oltean wrote:
> The Lynx PCS integrated with ENETC port 0 does not support in-band
> autoneg for the 2500base-x SERDES protocol, and prints errors from its
> phylink methods. Furthermore, the AQR112 card used for these boards does
> not expect in-band autoneg either. So delete the extraneous property.
> 
> Fixes: e426d63e752b ("arm64: dts: ls1028a-qds: add overlays for various serdes protocols")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
index 40d34c8384a5..b949cac03742 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
@@ -25,7 +25,6 @@  slot1_sgmii: ethernet-phy@2 {
 &enetc_port0 {
 	phy-handle = <&slot1_sgmii>;
 	phy-mode = "2500base-x";
-	managed = "in-band-status";
 	status = "okay";
 };