diff mbox series

Bluetooth: L2CAP: Fix l2cap_global_chan_by_psm regression

Message ID 20220801220426.2198967-1-luiz.dentz@gmail.com
State Superseded
Headers show
Series Bluetooth: L2CAP: Fix l2cap_global_chan_by_psm regression | expand

Commit Message

Luiz Augusto von Dentz Aug. 1, 2022, 10:04 p.m. UTC 
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

The patch d0be8347c623: "Bluetooth: L2CAP: Fix use-after-free caused
by l2cap_chan_put" from Jul 21, 2022, leads to the following Smatch
static checker warning:

        net/bluetooth/l2cap_core.c:1977 l2cap_global_chan_by_psm()
        error: we previously assumed 'c' could be null (see line 1996)

Fixes: d0be8347c623: "Bluetooth: L2CAP: Fix use-after-free caused by l2cap_chan_put"
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
 net/bluetooth/l2cap_core.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Comments

bluez.test.bot@gmail.com Aug. 1, 2022, 11:07 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=664631

---Test result---

Test Summary:
CheckPatch                    PASS      1.86 seconds
GitLint                       PASS      0.76 seconds
SubjectPrefix                 PASS      0.69 seconds
BuildKernel                   PASS      40.33 seconds
BuildKernel32                 PASS      35.03 seconds
Incremental Build with patchesPASS      48.21 seconds
TestRunner: Setup             PASS      575.07 seconds
TestRunner: l2cap-tester      PASS      19.89 seconds
TestRunner: bnep-tester       PASS      7.90 seconds
TestRunner: mgmt-tester       PASS      118.88 seconds
TestRunner: rfcomm-tester     PASS      11.58 seconds
TestRunner: sco-tester        PASS      11.33 seconds
TestRunner: smp-tester        PASS      10.88 seconds
TestRunner: userchan-tester   PASS      7.65 seconds



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 77c0aac14539..cbe0cae73434 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -1970,11 +1970,11 @@  static struct l2cap_chan *l2cap_global_chan_by_psm(int state, __le16 psm,
 						   bdaddr_t *dst,
 						   u8 link_type)
 {
-	struct l2cap_chan *c, *c1 = NULL;
+	struct l2cap_chan *c, *tmp, *c1 = NULL;
 
 	read_lock(&chan_list_lock);
 
-	list_for_each_entry(c, &chan_list, global_l) {
+	list_for_each_entry_safe(c, tmp, &chan_list, global_l) {
 		if (state && c->state != state)
 			continue;
 
@@ -1993,11 +1993,10 @@  static struct l2cap_chan *l2cap_global_chan_by_psm(int state, __le16 psm,
 			dst_match = !bacmp(&c->dst, dst);
 			if (src_match && dst_match) {
 				c = l2cap_chan_hold_unless_zero(c);
-				if (!c)
-					continue;
-
-				read_unlock(&chan_list_lock);
-				return c;
+				if (c) {
+					read_unlock(&chan_list_lock);
+					return c;
+				}
 			}
 
 			/* Closest match */