| Message ID | 20220722114136.251415-2-tmaimon77@gmail.com |
|---|---|
| State | Accepted |
| Commit | ac2c55e2260e0ae019119e1b2a52dda138039841 |
| Headers | show |
| Series | spi: npcm-pspi: add Arbel NPCM8XX support | expand |
Hi Rob, Thanks for your comments. On Tue, 26 Jul 2022 at 01:56, Rob Herring <robh@kernel.org> wrote: > > On Fri, Jul 22, 2022 at 02:41:35PM +0300, Tomer Maimon wrote: > > Add a compatible string for Nuvoton BMC NPCM845 PSPI. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt > > index b98203ca656d..a4e72e52af59 100644 > > --- a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt > > +++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt > > @@ -3,7 +3,8 @@ Nuvoton NPCM Peripheral Serial Peripheral Interface(PSPI) controller driver > > Nuvoton NPCM7xx SOC support two PSPI channels. > > > > Required properties: > > - - compatible : "nuvoton,npcm750-pspi" for NPCM7XX BMC > > + - compatible : "nuvoton,npcm750-pspi" for Poleg NPCM7XX. > > Who/What is Polog? Board/BMC vendor? If so, that should not be in SoC > bindings. > > > + "nuvoton,npcm845-pspi" for Arbel NPCM8XX. > > Same for Arbel. Poleg and Arbel are the name of the BMC SoC, will be removed next version. > > To answer your question on fallback, just put: > > "nuvoton,npcm845-pspi", "nuvoton,npcm750-pspi" for NPCM8XX BMC In the document? because I don't remember doing so in other documents that I use fallback. I need to do it in ymal files as well? > > > > - #address-cells : should be 1. see spi-bus.txt > > - #size-cells : should be 0. see spi-bus.txt > > - specifies physical base address and size of the register. > > -- > > 2.33.0 > > > > Best regards, Tomer
On 26/07/2022 11:30, Tomer Maimon wrote: >> To answer your question on fallback, just put: >> >> "nuvoton,npcm845-pspi", "nuvoton,npcm750-pspi" for NPCM8XX BMC > In the document? > because I don't remember doing so in other documents that I use fallback. If they also you fallbacks, then the other documents have now incorrect text. > I need to do it in ymal files as well? Depends on what you want to add and what you actually added... Let's be specific - point to specific commits or files in linux-next. If they were not applied - give lore.kernel.org link. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt index b98203ca656d..a4e72e52af59 100644 --- a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt +++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt @@ -3,7 +3,8 @@ Nuvoton NPCM Peripheral Serial Peripheral Interface(PSPI) controller driver Nuvoton NPCM7xx SOC support two PSPI channels. Required properties: - - compatible : "nuvoton,npcm750-pspi" for NPCM7XX BMC + - compatible : "nuvoton,npcm750-pspi" for Poleg NPCM7XX. + "nuvoton,npcm845-pspi" for Arbel NPCM8XX. - #address-cells : should be 1. see spi-bus.txt - #size-cells : should be 0. see spi-bus.txt - specifies physical base address and size of the register.
Add a compatible string for Nuvoton BMC NPCM845 PSPI. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)