| Message ID | 1658488552-24691-1-git-send-email-quic_zijuhu@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v5] Bluetooth: hci_sync: Remove redundant func definition | expand |
Hi Zijun,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth/master]
[also build test WARNING on net-next/master net/master linus/master v5.19]
[cannot apply to bluetooth-next/master next-20220812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zijun-Hu/Bluetooth-hci_sync-Remove-redundant-func-definition/20220722-191804
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20220814/202208142029.Y9YOiT4V-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/01ff3d2230c220a1387940ed594eccda09dc51fb
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Zijun-Hu/Bluetooth-hci_sync-Remove-redundant-func-definition/20220722-191804
git checkout 01ff3d2230c220a1387940ed594eccda09dc51fb
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/bluetooth/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/bluetooth/hci_sync.c:2398:6: warning: no previous prototype for 'disconnected_accept_list_entries' [-Wmissing-prototypes]
2398 | bool disconnected_accept_list_entries(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/disconnected_accept_list_entries +2398 net/bluetooth/hci_sync.c
2397
> 2398 bool disconnected_accept_list_entries(struct hci_dev *hdev)
2399 {
2400 struct bdaddr_list *b;
2401
2402 list_for_each_entry(b, &hdev->accept_list, list) {
2403 struct hci_conn *conn;
2404
2405 conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, &b->bdaddr);
2406 if (!conn)
2407 return true;
2408
2409 if (conn->state != BT_CONNECTED && conn->state != BT_CONFIG)
2410 return true;
2411 }
2412
2413 return false;
2414 }
2415
Hi Zijun,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth/master]
[also build test WARNING on net-next/master net/master linus/master v5.19]
[cannot apply to bluetooth-next/master next-20220812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zijun-Hu/Bluetooth-hci_sync-Remove-redundant-func-definition/20220722-191804
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
config: arm-defconfig (https://download.01.org/0day-ci/archive/20220814/202208142033.Kav1wBRp-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/01ff3d2230c220a1387940ed594eccda09dc51fb
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Zijun-Hu/Bluetooth-hci_sync-Remove-redundant-func-definition/20220722-191804
git checkout 01ff3d2230c220a1387940ed594eccda09dc51fb
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash net/bluetooth/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/bluetooth/hci_sync.c:2398:6: warning: no previous prototype for 'disconnected_accept_list_entries' [-Wmissing-prototypes]
2398 | bool disconnected_accept_list_entries(struct hci_dev *hdev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/disconnected_accept_list_entries +2398 net/bluetooth/hci_sync.c
2397
> 2398 bool disconnected_accept_list_entries(struct hci_dev *hdev)
2399 {
2400 struct bdaddr_list *b;
2401
2402 list_for_each_entry(b, &hdev->accept_list, list) {
2403 struct hci_conn *conn;
2404
2405 conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, &b->bdaddr);
2406 if (!conn)
2407 return true;
2408
2409 if (conn->state != BT_CONNECTED && conn->state != BT_CONFIG)
2410 return true;
2411 }
2412
2413 return false;
2414 }
2415
diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c index 635cc5fb451e..69e30217c4e4 100644 --- a/net/bluetooth/hci_request.c +++ b/net/bluetooth/hci_request.c @@ -32,6 +32,8 @@ #include "msft.h" #include "eir.h" +extern bool disconnected_accept_list_entries(struct hci_dev *hdev); + void hci_req_init(struct hci_request *req, struct hci_dev *hdev) { skb_queue_head_init(&req->cmd_q); @@ -1784,24 +1786,6 @@ int hci_update_random_address(struct hci_request *req, bool require_privacy, return 0; } -static bool disconnected_accept_list_entries(struct hci_dev *hdev) -{ - struct bdaddr_list *b; - - list_for_each_entry(b, &hdev->accept_list, list) { - struct hci_conn *conn; - - conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, &b->bdaddr); - if (!conn) - return true; - - if (conn->state != BT_CONNECTED && conn->state != BT_CONFIG) - return true; - } - - return false; -} - void __hci_req_update_scan(struct hci_request *req) { struct hci_dev *hdev = req->hdev; diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c index 3067d94e7a8e..b44d0b4143e6 100644 --- a/net/bluetooth/hci_sync.c +++ b/net/bluetooth/hci_sync.c @@ -2425,7 +2425,7 @@ int hci_write_fast_connectable_sync(struct hci_dev *hdev, bool enable) return err; } -static bool disconnected_accept_list_entries(struct hci_dev *hdev) +bool disconnected_accept_list_entries(struct hci_dev *hdev) { struct bdaddr_list *b;
both hci_request.c and hci_sync.c have the same definition for disconnected_accept_list_entries(), so remove a redundant copy. Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com> --- v4->v5 -move the func declaration from hci_request.h to hci_request.c v2->v4 -optimize commit message v1->v2 -remove the func copy within hci_request.c instead of hci_sync.c net/bluetooth/hci_request.c | 20 ++------------------ net/bluetooth/hci_sync.c | 2 +- 2 files changed, 3 insertions(+), 19 deletions(-)