[3/3] leds: leds-bcm63138: get rid of LED_OFF

Message ID	20220717124248.13562-4-zajec5@gmail.com
State	New
Headers	show Return-Path: <linux-leds-owner@kernel.org> From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com> To: Pavel Machek <pavel@ucw.cz> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, William Zhang <william.zhang@broadcom.com>, Anand Gore <anand.gore@broadcom.com>, Kursad Oney <kursad.oney@broadcom.com>, Florian Fainelli <f.fainelli@gmail.com>, linux-leds@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl> Subject: [PATCH 3/3] leds: leds-bcm63138: get rid of LED_OFF Date: Sun, 17 Jul 2022 14:42:48 +0200 Message-Id: <20220717124248.13562-4-zajec5@gmail.com> In-Reply-To: <20220717124248.13562-1-zajec5@gmail.com> References: <20220717124248.13562-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	leds-bcm63138: post apply/review fixes \| expand [0/3] leds-bcm63138: post apply/review fixes [1/3] dt-bindings: leds: leds-bcm63138: unify full stops in descriptions [2/3] leds: add help info about BCM63138 module name [3/3] leds: leds-bcm63138: get rid of LED_OFF

Message ID

20220717124248.13562-4-zajec5@gmail.com

State

New

Headers

From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 William Zhang <william.zhang@broadcom.com>,
 Anand Gore <anand.gore@broadcom.com>, Kursad Oney <kursad.oney@broadcom.com>,
 Florian Fainelli <f.fainelli@gmail.com>, linux-leds@vger.kernel.org,
 bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Subject: [PATCH 3/3] leds: leds-bcm63138: get rid of LED_OFF
Date: Sun, 17 Jul 2022 14:42:48 +0200
Message-Id: <20220717124248.13562-4-zajec5@gmail.com>
In-Reply-To: <20220717124248.13562-1-zajec5@gmail.com>
References: <20220717124248.13562-1-zajec5@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

leds-bcm63138: post apply/review fixes | expand

Commit Message

Rafał Miłecki July 17, 2022, 12:42 p.m. UTC

From: Rafał Miłecki <rafal@milecki.pl>

The whole "enum led_brightness" is marked as obsolete. Replace it with a
(non-)zero check.

Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/leds/blink/leds-bcm63138.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/leds/blink/leds-bcm63138.c b/drivers/leds/blink/leds-bcm63138.c
index c083cb1332cb..2cf2761e4914 100644
--- a/drivers/leds/blink/leds-bcm63138.c
+++ b/drivers/leds/blink/leds-bcm63138.c
@@ -113,8 +113,7 @@  static void bcm63138_leds_enable_led(struct bcm63138_leds *leds,
 {
 	u32 bit = BIT(led->pin);
 
-	bcm63138_leds_update_bits(leds, BCM63138_SW_DATA, bit,
-				  value == LED_OFF ? 0 : bit);
+	bcm63138_leds_update_bits(leds, BCM63138_SW_DATA, bit, value ? bit : 0);
 }
 
 /*

[3/3] leds: leds-bcm63138: get rid of LED_OFF

Commit Message

Patch