| Message ID | 20220713173920.222394-1-sakari.ailus@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] v4l: Kconfig: Drop subdev API option help text | expand |
Hi Sakari, Thank you for the patch. On Wed, Jul 13, 2022 at 08:39:20PM +0300, Sakari Ailus wrote: > The config option text was recently removed, also remove the help text. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/media/v4l2-core/Kconfig | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig > index 348559bc24689..60b0c6ee7343a 100644 > --- a/drivers/media/v4l2-core/Kconfig > +++ b/drivers/media/v4l2-core/Kconfig > @@ -11,11 +11,6 @@ config VIDEO_V4L2_I2C > config VIDEO_V4L2_SUBDEV_API > bool > depends on VIDEO_DEV && MEDIA_CONTROLLER > - help > - Enables the V4L2 sub-device pad-level userspace API used to configure > - video format, size and frame rate between hardware blocks. > - > - This API is mostly used by camera interfaces in embedded platforms. > > config VIDEO_ADV_DEBUG > bool "Enable advanced debug functionality on V4L2 drivers"
On Wed, Jul 13, 2022 at 10:32:55PM +0300, Laurent Pinchart wrote: > On Wed, Jul 13, 2022 at 08:54:12PM +0300, Laurent Pinchart wrote: > > Hi Sakari, > > > > Thank you for the patch. > > > > On Wed, Jul 13, 2022 at 08:39:20PM +0300, Sakari Ailus wrote: > > > The config option text was recently removed, also remove the help text. > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Actually, on second thought, isn't it useful to keep the help text as > documentation ? We haven't generally done that for other such options either. This was intended for end users IMO.
On Wed, Jul 13, 2022 at 10:41:01PM +0300, Sakari Ailus wrote: > On Wed, Jul 13, 2022 at 10:32:55PM +0300, Laurent Pinchart wrote: > > On Wed, Jul 13, 2022 at 08:54:12PM +0300, Laurent Pinchart wrote: > > > Hi Sakari, > > > > > > Thank you for the patch. > > > > > > On Wed, Jul 13, 2022 at 08:39:20PM +0300, Sakari Ailus wrote: > > > > The config option text was recently removed, also remove the help text. > > > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > > Actually, on second thought, isn't it useful to keep the help text as > > documentation ? > > We haven't generally done that for other such options either. This was > intended for end users IMO. I don't have a strong opinion, but this came to my attention when reviewing your patch that adds selection of GENERIC_PHY_MIPI_DPHY for sun6i. The GENERIC_PHY_MIPI_DPHY symbol isn't user-selectable but has a help text. A short documentation is useful in my opinion.
diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig index 348559bc24689..60b0c6ee7343a 100644 --- a/drivers/media/v4l2-core/Kconfig +++ b/drivers/media/v4l2-core/Kconfig @@ -11,11 +11,6 @@ config VIDEO_V4L2_I2C config VIDEO_V4L2_SUBDEV_API bool depends on VIDEO_DEV && MEDIA_CONTROLLER - help - Enables the V4L2 sub-device pad-level userspace API used to configure - video format, size and frame rate between hardware blocks. - - This API is mostly used by camera interfaces in embedded platforms. config VIDEO_ADV_DEBUG bool "Enable advanced debug functionality on V4L2 drivers"
The config option text was recently removed, also remove the help text. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/v4l2-core/Kconfig | 5 ----- 1 file changed, 5 deletions(-)