| Message ID | 20220713234655.3524356-1-luiz.dentz@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ] main: Default device_privacy to true | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=659495
---Test result---
Test Summary:
CheckPatch FAIL 1.66 seconds
GitLint PASS 1.07 seconds
Prep - Setup ELL PASS 27.63 seconds
Build - Prep PASS 0.85 seconds
Build - Configure PASS 8.67 seconds
Build - Make PASS 853.00 seconds
Make Check PASS 11.77 seconds
Make Check w/Valgrind PASS 284.25 seconds
Make Distcheck PASS 233.84 seconds
Build w/ext ELL - Configure PASS 8.70 seconds
Build w/ext ELL - Make PASS 80.81 seconds
Incremental Build w/ patches PASS 0.00 seconds
Scan Build PASS 483.54 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ] main: Default device_privacy to true
WARNING:REPEATED_WORD: Possible repeated word: 'the'
#81:
otherwise network mode would prevent reconnections if the the identity
/github/workspace/src/12917203.patch total: 0 errors, 1 warnings, 14 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12917203.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 13 Jul 2022 16:46:55 -0700 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > If privacy mode is not strictly set to network set it to device > otherwise network mode would prevent reconnections if the the identity > address is used: > > BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 6, Part B page 2837-2838 > > [...] Here is the summary with links: - [BlueZ] main: Default device_privacy to true https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=af998fd32c34 You are awesome, thank you!
diff --git a/src/main.c b/src/main.c index 34a54d43f..4ee96bc6a 100644 --- a/src/main.c +++ b/src/main.c @@ -699,6 +699,7 @@ static void parse_config(GKeyFile *config) DBG("%s", err->message); g_clear_error(&err); btd_opts.privacy = 0x00; + btd_opts.device_privacy = true; } else { DBG("privacy=%s", str); @@ -722,6 +723,7 @@ static void parse_config(GKeyFile *config) btd_opts.device_privacy = true; } else if (!strcmp(str, "off")) { btd_opts.privacy = 0x00; + btd_opts.device_privacy = true; } else { DBG("Invalid privacy option: %s", str); btd_opts.privacy = 0x00;
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> If privacy mode is not strictly set to network set it to device otherwise network mode would prevent reconnections if the the identity address is used: BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 6, Part B page 2837-2838 'The Host specifies the privacy mode to be used with each peer identity on the resolving list. If it specifies that device privacy mode is to be used, then the Controller shall accept both the peer's device Identity Address and a resolvable private address generated by the peer device using its distributed IRK. Otherwise, network privacy mode is used: the Controller shall only accept resolvable private addresses generated by the peer device using its distributed IRK.' --- src/main.c | 2 ++ 1 file changed, 2 insertions(+)