| Message ID | 20220711144039.232196-2-y.oudjana@protonmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: i2c: ak7375: Add regulator management | expand |
On 11/07/2022 16:40, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Convert DT bindings document for AKM AK7375 VCM to DT schema > format and add an example. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hello, I have been testing this VCM in conjunction with Arducam's IMX519 sensor with libcamera and an autofocus algorithm plumbed in libcamera [1] On 7/11/22 8:10 PM, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Convert DT bindings document for AKM AK7375 VCM to DT schema > format and add an example. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> So, Tested-by: Umang Jain <umang.jain@ideasonboard.com> [1] https://patchwork.libcamera.org/project/libcamera/list/?series=3174 > --- > Changes since v1: > - Add vendor prefix to DT binding doc file name > > .../devicetree/bindings/media/i2c/ak7375.txt | 8 ---- > .../media/i2c/asahi-kasei,ak7375.yaml | 41 +++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 42 insertions(+), 9 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/i2c/ak7375.txt > create mode 100644 Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/ak7375.txt b/Documentation/devicetree/bindings/media/i2c/ak7375.txt > deleted file mode 100644 > index aa3e24b41241..000000000000 > --- a/Documentation/devicetree/bindings/media/i2c/ak7375.txt > +++ /dev/null > @@ -1,8 +0,0 @@ > -Asahi Kasei Microdevices AK7375 voice coil lens driver > - > -AK7375 is a camera voice coil lens. > - > -Mandatory properties: > - > -- compatible: "asahi-kasei,ak7375" > -- reg: I2C slave address > diff --git a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml > new file mode 100644 > index 000000000000..22b1251b16ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/asahi-kasei,ak7375.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Asahi Kasei Microdevices AK7375 voice coil lens actuator > + > +maintainers: > + - Tianshu Qiu <tian.shu.qiu@intel.com> > + > +description: > + AK7375 is a voice coil motor (VCM) camera lens actuator that > + is controlled over I2C. > + > +properties: > + compatible: > + const: asahi-kasei,ak7375 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ak7375: camera-lens@c { > + compatible = "asahi-kasei,ak7375"; > + reg = <0x0c>; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index a97fef8c131d..e6accf8bc12b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3063,7 +3063,7 @@ M: Tianshu Qiu <tian.shu.qiu@intel.com> > L: linux-media@vger.kernel.org > S: Maintained > T: git git://linuxtv.org/media_tree.git > -F: Documentation/devicetree/bindings/media/i2c/ak7375.txt > +F: Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml > F: drivers/media/i2c/ak7375.c > > ASAHI KASEI AK8974 DRIVER
diff --git a/Documentation/devicetree/bindings/media/i2c/ak7375.txt b/Documentation/devicetree/bindings/media/i2c/ak7375.txt deleted file mode 100644 index aa3e24b41241..000000000000 --- a/Documentation/devicetree/bindings/media/i2c/ak7375.txt +++ /dev/null @@ -1,8 +0,0 @@ -Asahi Kasei Microdevices AK7375 voice coil lens driver - -AK7375 is a camera voice coil lens. - -Mandatory properties: - -- compatible: "asahi-kasei,ak7375" -- reg: I2C slave address diff --git a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml new file mode 100644 index 000000000000..22b1251b16ee --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml @@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/asahi-kasei,ak7375.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Asahi Kasei Microdevices AK7375 voice coil lens actuator + +maintainers: + - Tianshu Qiu <tian.shu.qiu@intel.com> + +description: + AK7375 is a voice coil motor (VCM) camera lens actuator that + is controlled over I2C. + +properties: + compatible: + const: asahi-kasei,ak7375 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ak7375: camera-lens@c { + compatible = "asahi-kasei,ak7375"; + reg = <0x0c>; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index a97fef8c131d..e6accf8bc12b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3063,7 +3063,7 @@ M: Tianshu Qiu <tian.shu.qiu@intel.com> L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media_tree.git -F: Documentation/devicetree/bindings/media/i2c/ak7375.txt +F: Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml F: drivers/media/i2c/ak7375.c ASAHI KASEI AK8974 DRIVER