diff mbox series

[v2,1/3] dt-bindings: dmaengine: Add compatible for Tegra234

Message ID 20220707145729.41876-2-akhilrajeev@nvidia.com
State Superseded
Headers show
Series [v2,1/3] dt-bindings: dmaengine: Add compatible for Tegra234 | expand

Commit Message

Akhil R July 7, 2022, 2:57 p.m. UTC
Document the compatible string used by GPCDMA controller for Tegra234.

Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
---
 .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml         | 1 +
 1 file changed, 1 insertion(+)

Comments

Thierry Reding July 8, 2022, 2:35 p.m. UTC | #1
On Thu, Jul 07, 2022 at 08:27:27PM +0530, Akhil R wrote:
> Document the compatible string used by GPCDMA controller for Tegra234.
> 
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
>  .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml         | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> index 9dd1476d1849..81f3badbc8ec 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> @@ -23,6 +23,7 @@ properties:
>      oneOf:
>        - const: nvidia,tegra186-gpcdma
>        - items:
> +          - const: nvidia,tegra234-gpcdma
>            - const: nvidia,tegra194-gpcdma
>            - const: nvidia,tegra186-gpcdma

I don't think this works because it will now fail to validate Tegra194
device trees. You'll need to create a separate set of items for
Tegra234.

Thierry
Akhil R July 8, 2022, 4:10 p.m. UTC | #2
> On Thu, Jul 07, 2022 at 08:27:27PM +0530, Akhil R wrote:
> > Document the compatible string used by GPCDMA controller for Tegra234.
> >
> > Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> > ---
> >  .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml         | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > index 9dd1476d1849..81f3badbc8ec 100644
> > ---
> > a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.ya
> > +++ ml
> > @@ -23,6 +23,7 @@ properties:
> >      oneOf:
> >        - const: nvidia,tegra186-gpcdma
> >        - items:
> > +          - const: nvidia,tegra234-gpcdma
> >            - const: nvidia,tegra194-gpcdma
> >            - const: nvidia,tegra186-gpcdma
> 
> I don't think this works because it will now fail to validate Tegra194 device trees.
> You'll need to create a separate set of items for Tegra234.

If I update it as below, would it work?

- items:
	- const: nvidia,tegra234-gpcdma
	- const: nvidia,tegra186-gpcdma

- items:
	- const: nvidia,tegra194-gpcdma
	- const: nvidia,tegra186-gpcdma

Regards,
Akhil

--
nvpublic
Thierry Reding July 8, 2022, 5:48 p.m. UTC | #3
On Fri, Jul 08, 2022 at 04:10:47PM +0000, Akhil R wrote:
> > On Thu, Jul 07, 2022 at 08:27:27PM +0530, Akhil R wrote:
> > > Document the compatible string used by GPCDMA controller for Tegra234.
> > >
> > > Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> > > ---
> > >  .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml         | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > > b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > > index 9dd1476d1849..81f3badbc8ec 100644
> > > ---
> > > a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > > +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.ya
> > > +++ ml
> > > @@ -23,6 +23,7 @@ properties:
> > >      oneOf:
> > >        - const: nvidia,tegra186-gpcdma
> > >        - items:
> > > +          - const: nvidia,tegra234-gpcdma
> > >            - const: nvidia,tegra194-gpcdma
> > >            - const: nvidia,tegra186-gpcdma
> > 
> > I don't think this works because it will now fail to validate Tegra194 device trees.
> > You'll need to create a separate set of items for Tegra234.
> 
> If I update it as below, would it work?
> 
> - items:
> 	- const: nvidia,tegra234-gpcdma
> 	- const: nvidia,tegra186-gpcdma
> 
> - items:
> 	- const: nvidia,tegra194-gpcdma
> 	- const: nvidia,tegra186-gpcdma

Yeah, that should work. You can verify that this works by running the
dtbs_check target, although this can be somewhat overwhelming right now
given that there are quite a few errors/warnings, so it's easy to miss
new ones.

According to the DTS change that you posted as part of this series, the
Tegra234 compatible string list also includes the Tegra194 compatible
string, so that should either also be updated, or you need to include it
in the binding as well, like in your original patch.

Thierry
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
index 9dd1476d1849..81f3badbc8ec 100644
--- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
@@ -23,6 +23,7 @@  properties:
     oneOf:
       - const: nvidia,tegra186-gpcdma
       - items:
+          - const: nvidia,tegra234-gpcdma
           - const: nvidia,tegra194-gpcdma
           - const: nvidia,tegra186-gpcdma