| Message ID | 1657135928-31195-1-git-send-email-quic_khsieh@quicinc.com |
|---|---|
| State | Accepted |
| Commit | deffa2d75db7e7a9a1fe3dad4f99310bff7b6449 |
| Headers | show |
| Series | [v4] drm/msm/dp: make eDP panel as the first connected connector | expand |
Quoting Kuogee Hsieh (2022-07-06 12:32:08) > Some userspace presumes that the first connected connector is the main > display, where it's supposed to display e.g. the login screen. For > laptops, this should be the main panel. > > This patch call drm_helper_move_panel_connectors_to_head() after > drm_bridge_connector_init() to make sure eDP stay at head of > connected connector list. This fixes unexpected corruption happen > at eDP panel if eDP is not placed at head of connected connector > list. > > Changes in v2: > -- move drm_helper_move_panel_connectors_to_head() to > dpu_kms_drm_obj_init() > > Changes in v4: > -- move drm_helper_move_panel_connectors_to_head() to msm_drm_init() > > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
On 7/6/2022 12:32 PM, Kuogee Hsieh wrote: > Some userspace presumes that the first connected connector is the main > display, where it's supposed to display e.g. the login screen. For > laptops, this should be the main panel. > > This patch call drm_helper_move_panel_connectors_to_head() after > drm_bridge_connector_init() to make sure eDP stay at head of > connected connector list. This fixes unexpected corruption happen > at eDP panel if eDP is not placed at head of connected connector > list. > > Changes in v2: > -- move drm_helper_move_panel_connectors_to_head() to > dpu_kms_drm_obj_init() > > Changes in v4: > -- move drm_helper_move_panel_connectors_to_head() to msm_drm_init() > > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> Fixes: c8afe684c95c ("drm/msm: basic KMS driver for snapdragon") > --- > drivers/gpu/drm/msm/msm_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 4a3dda2..4d518c2 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -419,6 +419,8 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) > } > } > > + drm_helper_move_panel_connectors_to_head(ddev); > + > ddev->mode_config.funcs = &mode_config_funcs; > ddev->mode_config.helper_private = &mode_config_helper_funcs; >
On 7/20/2022 11:47 AM, Abhinav Kumar wrote: > > > On 7/6/2022 12:32 PM, Kuogee Hsieh wrote: >> Some userspace presumes that the first connected connector is the main >> display, where it's supposed to display e.g. the login screen. For >> laptops, this should be the main panel. >> >> This patch call drm_helper_move_panel_connectors_to_head() after >> drm_bridge_connector_init() to make sure eDP stay at head of >> connected connector list. This fixes unexpected corruption happen >> at eDP panel if eDP is not placed at head of connected connector >> list. >> >> Changes in v2: >> -- move drm_helper_move_panel_connectors_to_head() to >> dpu_kms_drm_obj_init() >> >> Changes in v4: >> -- move drm_helper_move_panel_connectors_to_head() to msm_drm_init() >> >> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > Fixes: c8afe684c95c ("drm/msm: basic KMS driver for snapdragon") Lets drop the previous fixes tag and use this one as its more recent and appropriate as it added eDP support for sc7280. Fixes: ef7837ff091c ("drm/msm/dp: Add DP controllers for sc7280") >> --- >> drivers/gpu/drm/msm/msm_drv.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/msm_drv.c >> b/drivers/gpu/drm/msm/msm_drv.c >> index 4a3dda2..4d518c2 100644 >> --- a/drivers/gpu/drm/msm/msm_drv.c >> +++ b/drivers/gpu/drm/msm/msm_drv.c >> @@ -419,6 +419,8 @@ static int msm_drm_init(struct device *dev, const >> struct drm_driver *drv) >> } >> } >> + drm_helper_move_panel_connectors_to_head(ddev); >> + >> ddev->mode_config.funcs = &mode_config_funcs; >> ddev->mode_config.helper_private = &mode_config_helper_funcs;
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 4a3dda2..4d518c2 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -419,6 +419,8 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) } } + drm_helper_move_panel_connectors_to_head(ddev); + ddev->mode_config.funcs = &mode_config_funcs; ddev->mode_config.helper_private = &mode_config_helper_funcs;
Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_move_panel_connectors_to_head() after drm_bridge_connector_init() to make sure eDP stay at head of connected connector list. This fixes unexpected corruption happen at eDP panel if eDP is not placed at head of connected connector list. Changes in v2: -- move drm_helper_move_panel_connectors_to_head() to dpu_kms_drm_obj_init() Changes in v4: -- move drm_helper_move_panel_connectors_to_head() to msm_drm_init() Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> --- drivers/gpu/drm/msm/msm_drv.c | 2 ++ 1 file changed, 2 insertions(+)