diff mbox

IRQ/Platform-MSI:Increase the maximum MSIs the MSI framework can support.

Message ID 1450667905-2968-1-git-send-email-majun258@huawei.com
State Accepted
Commit aff5e06b0dda7704ff2fa45162cfc4dde316a6f1
Headers show

Commit Message

majun (F) Dec. 21, 2015, 3:18 a.m. UTC
From: Ma Jun <majun258@huawei.com>


The current MSI framework can only support 256 platform MSIs.

But on Hisilicon platform, some network related devices has about 500
wired interrupts.

To support these devices, we need a new maximum value more than 256.

Signed-off-by: Ma Jun <majun258@huawei.com>

---
 drivers/base/platform-msi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-- 
1.7.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

majun (F) Dec. 22, 2015, 2:46 a.m. UTC | #1
在 2015/12/21 18:43, Marc Zyngier 写道:
> On Mon, 21 Dec 2015 11:18:25 +0800

> MaJun <majun258@huawei.com> wrote:

> 

>> From: Ma Jun <majun258@huawei.com>

>>

>> The current MSI framework can only support 256 platform MSIs.

>>

>> But on Hisilicon platform, some network related devices has about 500

>> wired interrupts.

>>

>> To support these devices, we need a new maximum value more than 256.

>>

>> Signed-off-by: Ma Jun <majun258@huawei.com>

>> ---

>>  drivers/base/platform-msi.c |    2 +-

>>  1 files changed, 1 insertions(+), 1 deletions(-)

>>

>> diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c

>> index a203896..9c00d3f 100644

>> --- a/drivers/base/platform-msi.c

>> +++ b/drivers/base/platform-msi.c

>> @@ -24,7 +24,7 @@

>>  #include <linux/msi.h>

>>  #include <linux/slab.h>

>>  

>> -#define DEV_ID_SHIFT	24

>> +#define DEV_ID_SHIFT	22

>>  #define MAX_DEV_MSIS	(1 << (32 - DEV_ID_SHIFT))

>>  

>>  /*

> 

> If we bother doing that, why not directly aligning it with MSI-X and

> allow up to 2048 interrupts per device? It is only an extra bit, and

> that still leaves 21 bits worth of device IDs, while still having

> hwirq as an unsigned long (32bit on 32bit architectures).

> 


Ok, I'll changed this value to 2048

Thanks
Ma Jun
> Thanks,

> 

> 	M.

> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
diff mbox

Patch

diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c
index a203896..9c00d3f 100644
--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -24,7 +24,7 @@ 
 #include <linux/msi.h>
 #include <linux/slab.h>
 
-#define DEV_ID_SHIFT	24
+#define DEV_ID_SHIFT	22
 #define MAX_DEV_MSIS	(1 << (32 - DEV_ID_SHIFT))
 
 /*