| Message ID | 4b3c4c8f-02b0-4d95-85ef-9368b5557cbf@I-love.SAKURA.ne.jp |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/4] scsi: qla2xxx: Remove unused del_sess_list field | expand |
Nilesh, > "struct qla_tgt"->del_sess_list is no longer used since commit > 726b85487067d7f5 ("qla2xxx: Add framework for async fabric discovery"). Please review and test this series. Thank you!
Nilesh, I still can't find this series in linux-next.git. What is the status of this series? On 2022/07/08 6:35, Martin K. Petersen wrote: > > Nilesh, > >> "struct qla_tgt"->del_sess_list is no longer used since commit >> 726b85487067d7f5 ("qla2xxx: Add framework for async fabric discovery"). > > Please review and test this series. Thank you! >
Hi Tetsuo, > On Aug 5, 2022, at 3:04 AM, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote: > > Nilesh, I still can't find this series in linux-next.git. > > What is the status of this series? > > On 2022/07/08 6:35, Martin K. Petersen wrote: >> >> Nilesh, >> >>> "struct qla_tgt"->del_sess_list is no longer used since commit >>> 726b85487067d7f5 ("qla2xxx: Add framework for async fabric discovery"). >> >> Please review and test this series. Thank you! >> > I have reviewed and tested this series in my limited Target setup with QLE adapters. Would you please resend this series. You can add Tested-by: Himanshu Madhani <himanshu.madhani@oracle.com> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 2b2f68288375..d9e0e7ffe130 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -6512,7 +6512,6 @@ int qlt_add_target(struct qla_hw_data *ha, struct scsi_qla_host *base_vha) tgt->ha = ha; tgt->vha = base_vha; init_waitqueue_head(&tgt->waitQ); - INIT_LIST_HEAD(&tgt->del_sess_list); spin_lock_init(&tgt->sess_work_lock); INIT_WORK(&tgt->sess_work, qlt_sess_work_fn); INIT_LIST_HEAD(&tgt->sess_works_list); diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h index de3942b8efc4..e899e13696e9 100644 --- a/drivers/scsi/qla2xxx/qla_target.h +++ b/drivers/scsi/qla2xxx/qla_target.h @@ -813,9 +813,6 @@ struct qla_tgt { /* Count of sessions refering qla_tgt. Protected by hardware_lock. */ int sess_count; - /* Protected by hardware_lock */ - struct list_head del_sess_list; - spinlock_t sess_work_lock; struct list_head sess_works_list; struct work_struct sess_work;
"struct qla_tgt"->del_sess_list is no longer used since commit 726b85487067d7f5 ("qla2xxx: Add framework for async fabric discovery"). Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> --- Changes in v4: Repost as a new thread. drivers/scsi/qla2xxx/qla_target.c | 1 - drivers/scsi/qla2xxx/qla_target.h | 3 --- 2 files changed, 4 deletions(-)