diff mbox series

[net,2/3] selftests: forwarding: fix learning_test when h1 supports IFF_UNICAST_FLT

Message ID 20220703073626.937785-3-vladimir.oltean@nxp.com
State Accepted
Commit 1a635d3e1c80626237fdae47a5545b6655d8d81c
Headers show
Series Fix bridge_vlan_aware.sh and bridge_vlan_unaware.sh with IFF_UNICAST_FLT | expand

Commit Message

Vladimir Oltean July 3, 2022, 7:36 a.m. UTC
The first host interface has by default no interest in receiving packets
MAC DA de:ad:be:ef:13:37, so it might drop them before they hit the tc
filter and this might confuse the selftest.

Enable promiscuous mode such that the filter properly counts received
packets.

Fixes: d4deb01467ec ("selftests: forwarding: Add a test for FDB learning")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 tools/testing/selftests/net/forwarding/lib.sh | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ido Schimmel July 3, 2022, 10:03 a.m. UTC | #1
On Sun, Jul 03, 2022 at 10:36:25AM +0300, Vladimir Oltean wrote:
> The first host interface has by default no interest in receiving packets
> MAC DA de:ad:be:ef:13:37, so it might drop them before they hit the tc
> filter and this might confuse the selftest.
> 
> Enable promiscuous mode such that the filter properly counts received
> packets.
> 
> Fixes: d4deb01467ec ("selftests: forwarding: Add a test for FDB learning")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
index 4e69497f021f..26ba8b5d264a 100755
--- a/tools/testing/selftests/net/forwarding/lib.sh
+++ b/tools/testing/selftests/net/forwarding/lib.sh
@@ -1240,6 +1240,7 @@  learning_test()
 	# FDB entry was installed.
 	bridge link set dev $br_port1 flood off
 
+	ip link set $host1_if promisc on
 	tc qdisc add dev $host1_if ingress
 	tc filter add dev $host1_if ingress protocol ip pref 1 handle 101 \
 		flower dst_mac $mac action drop
@@ -1289,6 +1290,7 @@  learning_test()
 
 	tc filter del dev $host1_if ingress protocol ip pref 1 handle 101 flower
 	tc qdisc del dev $host1_if ingress
+	ip link set $host1_if promisc off
 
 	bridge link set dev $br_port1 flood on