| Message ID | 20220629123543.94515-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: soc: samsung: s5pv210-chipid: add S5PV210 ChipID | expand |
On Wed, Jun 29, 2022 at 02:35:43PM +0200, Krzysztof Kozlowski wrote: > Add bindings for the S5PV210 ChipID block. Is this new or was undocumented? > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/soc/samsung/s5pv210-chipid.yaml | 30 +++++++++++++++++++ samsung,s5pv210-chipid.yaml Surely there's other similar blocks. Can we start collecting in a common directory? > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/samsung/s5pv210-chipid.yaml > > diff --git a/Documentation/devicetree/bindings/soc/samsung/s5pv210-chipid.yaml b/Documentation/devicetree/bindings/soc/samsung/s5pv210-chipid.yaml > new file mode 100644 > index 000000000000..7c3f4ec47f7e > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/samsung/s5pv210-chipid.yaml > @@ -0,0 +1,30 @@ > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/samsung/s5pv210-chipid.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung S5PV210 SoC series Chipid driver > + > +maintainers: > + - Krzysztof Kozlowski <krzk@kernel.org> > + > +properties: > + compatible: > + const: samsung,s5pv210-chipid > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + chipid@e0000000 { > + compatible = "samsung,s5pv210-chipid"; > + reg = <0xe0000000 0x1000>; > + }; > -- > 2.34.1 > >
On 01/07/2022 19:35, Rob Herring wrote: > On Wed, Jun 29, 2022 at 02:35:43PM +0200, Krzysztof Kozlowski wrote: >> Add bindings for the S5PV210 ChipID block. > > Is this new or was undocumented? Undocumented, I'll mention in the commit msg. > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../bindings/soc/samsung/s5pv210-chipid.yaml | 30 +++++++++++++++++++ > > samsung,s5pv210-chipid.yaml Hm, even for files under "samsung" directory? > > Surely there's other similar blocks. Can we start collecting in a > common directory? It's a soc-specific driver, type of soc_device. If you think it's worth a place of its own, I can put it somewhere dedicated. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/soc/samsung/s5pv210-chipid.yaml b/Documentation/devicetree/bindings/soc/samsung/s5pv210-chipid.yaml new file mode 100644 index 000000000000..7c3f4ec47f7e --- /dev/null +++ b/Documentation/devicetree/bindings/soc/samsung/s5pv210-chipid.yaml @@ -0,0 +1,30 @@ +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/samsung/s5pv210-chipid.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung S5PV210 SoC series Chipid driver + +maintainers: + - Krzysztof Kozlowski <krzk@kernel.org> + +properties: + compatible: + const: samsung,s5pv210-chipid + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + chipid@e0000000 { + compatible = "samsung,s5pv210-chipid"; + reg = <0xe0000000 0x1000>; + };
Add bindings for the S5PV210 ChipID block. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/soc/samsung/s5pv210-chipid.yaml | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/samsung/s5pv210-chipid.yaml