diff mbox

validation: classification: check return value of pktio stop

Message ID 1450094431-18859-1-git-send-email-bala.manoharan@linaro.org
State Accepted
Commit bee61210d6a24a564213ff194e788f6ab81f9c6b
Headers show

Commit Message

Balasubramanian Manoharan Dec. 14, 2015, noon UTC
Fixes https://bugs.linaro.org/show_bug.cgi?id=1937

Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
---
 test/validation/classification/odp_classification_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Bill Fischofer Dec. 14, 2015, 12:29 p.m. UTC | #1
On Mon, Dec 14, 2015 at 6:00 AM, Balasubramanian Manoharan <
bala.manoharan@linaro.org> wrote:

> Fixes https://bugs.linaro.org/show_bug.cgi?id=1937

>

> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>

>


Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>



> ---

>  test/validation/classification/odp_classification_common.c | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

>

> diff --git a/test/validation/classification/odp_classification_common.c

> b/test/validation/classification/odp_classification_common.c

> index 665e67c..a56c017 100644

> --- a/test/validation/classification/odp_classification_common.c

> +++ b/test/validation/classification/odp_classification_common.c

> @@ -29,7 +29,8 @@ int destroy_inq(odp_pktio_t pktio)

>                 return -1;

>         }

>

> -       odp_pktio_stop(pktio);

> +       if (0 > odp_pktio_stop(pktio))

> +               return -1;

>

>         if (0 > odp_pktio_inq_remdef(pktio))

>                 return -1;

> --

> 1.9.1

>

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp

>
Maxim Uvarov Dec. 14, 2015, 12:56 p.m. UTC | #2
Merged,
Maxim.

On 12/14/2015 15:29, Bill Fischofer wrote:
>
>
> On Mon, Dec 14, 2015 at 6:00 AM, Balasubramanian Manoharan 
> <bala.manoharan@linaro.org <mailto:bala.manoharan@linaro.org>> wrote:
>
>     Fixes https://bugs.linaro.org/show_bug.cgi?id=1937
>
>     Signed-off-by: Balasubramanian Manoharan
>     <bala.manoharan@linaro.org <mailto:bala.manoharan@linaro.org>>
>
>
> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org 
> <mailto:bill.fischofer@linaro.org>>
>
>     ---
>      test/validation/classification/odp_classification_common.c | 3 ++-
>      1 file changed, 2 insertions(+), 1 deletion(-)
>
>     diff --git
>     a/test/validation/classification/odp_classification_common.c
>     b/test/validation/classification/odp_classification_common.c
>     index 665e67c..a56c017 100644
>     --- a/test/validation/classification/odp_classification_common.c
>     +++ b/test/validation/classification/odp_classification_common.c
>     @@ -29,7 +29,8 @@ int destroy_inq(odp_pktio_t pktio)
>                     return -1;
>             }
>
>     -       odp_pktio_stop(pktio);
>     +       if (0 > odp_pktio_stop(pktio))
>     +               return -1;
>
>             if (0 > odp_pktio_inq_remdef(pktio))
>                     return -1;
>     --
>     1.9.1
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/test/validation/classification/odp_classification_common.c b/test/validation/classification/odp_classification_common.c
index 665e67c..a56c017 100644
--- a/test/validation/classification/odp_classification_common.c
+++ b/test/validation/classification/odp_classification_common.c
@@ -29,7 +29,8 @@  int destroy_inq(odp_pktio_t pktio)
 		return -1;
 	}
 
-	odp_pktio_stop(pktio);
+	if (0 > odp_pktio_stop(pktio))
+		return -1;
 
 	if (0 > odp_pktio_inq_remdef(pktio))
 		return -1;