Message ID | 20220618222317.478187-1-marex@denx.de |
---|---|
State | Accepted |
Commit | 90f8cb5154944dbe6f4dd630dc23f7ddbac624f6 |
Headers | show |
Series | media: stm32: dcmi: Fill in remaining Bayer formats | expand |
Hi Marek, Thanks for the patch. Acked-by: Hugues Fruchet <hugues.fruchet@st.com> Please note that we have not tested parallel setup with more than 8 bits with this driver because of lack of hardware support. Which board are you using ? Are the whole 12 bits of the MT9P006 parallel bus wired on your board ? Best regards, Hugues. On 6/19/22 00:23, Marek Vasut wrote: > Fill in 10, 12, 14 bit Bayer formats into the DCMI driver. > Those are useful e.g. when MT9P006 sensor is connected. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Alain Volmat <alain.volmat@foss.st.com> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Amelie DELAUNAY <amelie.delaunay@foss.st.com> > Cc: Hugues FRUCHET <hugues.fruchet@foss.st.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Philippe CORNU <philippe.cornu@foss.st.com> > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/media/platform/st/stm32/stm32-dcmi.c | 48 ++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c > index 09a743cd70040..5f08ba47ea96b 100644 > --- a/drivers/media/platform/st/stm32/stm32-dcmi.c > +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c > @@ -1631,6 +1631,54 @@ static const struct dcmi_format dcmi_formats[] = { > .fourcc = V4L2_PIX_FMT_SRGGB8, > .mbus_code = MEDIA_BUS_FMT_SRGGB8_1X8, > .bpp = 1, > + }, { > + .fourcc = V4L2_PIX_FMT_SBGGR10, > + .mbus_code = MEDIA_BUS_FMT_SBGGR10_1X10, > + .bpp = 2, > + }, { > + .fourcc = V4L2_PIX_FMT_SGBRG10, > + .mbus_code = MEDIA_BUS_FMT_SGBRG10_1X10, > + .bpp = 2, > + }, { > + .fourcc = V4L2_PIX_FMT_SGRBG10, > + .mbus_code = MEDIA_BUS_FMT_SGRBG10_1X10, > + .bpp = 2, > + }, { > + .fourcc = V4L2_PIX_FMT_SRGGB10, > + .mbus_code = MEDIA_BUS_FMT_SRGGB10_1X10, > + .bpp = 2, > + }, { > + .fourcc = V4L2_PIX_FMT_SBGGR12, > + .mbus_code = MEDIA_BUS_FMT_SBGGR12_1X12, > + .bpp = 2, > + }, { > + .fourcc = V4L2_PIX_FMT_SGBRG12, > + .mbus_code = MEDIA_BUS_FMT_SGBRG12_1X12, > + .bpp = 2, > + }, { > + .fourcc = V4L2_PIX_FMT_SGRBG12, > + .mbus_code = MEDIA_BUS_FMT_SGRBG12_1X12, > + .bpp = 2, > + }, { > + .fourcc = V4L2_PIX_FMT_SRGGB12, > + .mbus_code = MEDIA_BUS_FMT_SRGGB12_1X12, > + .bpp = 2, > + }, { > + .fourcc = V4L2_PIX_FMT_SBGGR14, > + .mbus_code = MEDIA_BUS_FMT_SBGGR14_1X14, > + .bpp = 2, > + }, { > + .fourcc = V4L2_PIX_FMT_SGBRG14, > + .mbus_code = MEDIA_BUS_FMT_SGBRG14_1X14, > + .bpp = 2, > + }, { > + .fourcc = V4L2_PIX_FMT_SGRBG14, > + .mbus_code = MEDIA_BUS_FMT_SGRBG14_1X14, > + .bpp = 2, > + }, { > + .fourcc = V4L2_PIX_FMT_SRGGB14, > + .mbus_code = MEDIA_BUS_FMT_SRGGB14_1X14, > + .bpp = 2, > }, > }; >
On 6/27/22 11:39, Hugues FRUCHET wrote: > Hi Marek, Hi, > Thanks for the patch. > > Acked-by: Hugues Fruchet <hugues.fruchet@st.com> > > Please note that we have not tested parallel setup with more than 8 bits > with this driver because of lack of hardware support. > Which board are you using ? Custom one with MT9P006 sensor. > Are the whole 12 bits of the MT9P006 parallel bus wired on your board ? Yes
diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c index 09a743cd70040..5f08ba47ea96b 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmi.c +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c @@ -1631,6 +1631,54 @@ static const struct dcmi_format dcmi_formats[] = { .fourcc = V4L2_PIX_FMT_SRGGB8, .mbus_code = MEDIA_BUS_FMT_SRGGB8_1X8, .bpp = 1, + }, { + .fourcc = V4L2_PIX_FMT_SBGGR10, + .mbus_code = MEDIA_BUS_FMT_SBGGR10_1X10, + .bpp = 2, + }, { + .fourcc = V4L2_PIX_FMT_SGBRG10, + .mbus_code = MEDIA_BUS_FMT_SGBRG10_1X10, + .bpp = 2, + }, { + .fourcc = V4L2_PIX_FMT_SGRBG10, + .mbus_code = MEDIA_BUS_FMT_SGRBG10_1X10, + .bpp = 2, + }, { + .fourcc = V4L2_PIX_FMT_SRGGB10, + .mbus_code = MEDIA_BUS_FMT_SRGGB10_1X10, + .bpp = 2, + }, { + .fourcc = V4L2_PIX_FMT_SBGGR12, + .mbus_code = MEDIA_BUS_FMT_SBGGR12_1X12, + .bpp = 2, + }, { + .fourcc = V4L2_PIX_FMT_SGBRG12, + .mbus_code = MEDIA_BUS_FMT_SGBRG12_1X12, + .bpp = 2, + }, { + .fourcc = V4L2_PIX_FMT_SGRBG12, + .mbus_code = MEDIA_BUS_FMT_SGRBG12_1X12, + .bpp = 2, + }, { + .fourcc = V4L2_PIX_FMT_SRGGB12, + .mbus_code = MEDIA_BUS_FMT_SRGGB12_1X12, + .bpp = 2, + }, { + .fourcc = V4L2_PIX_FMT_SBGGR14, + .mbus_code = MEDIA_BUS_FMT_SBGGR14_1X14, + .bpp = 2, + }, { + .fourcc = V4L2_PIX_FMT_SGBRG14, + .mbus_code = MEDIA_BUS_FMT_SGBRG14_1X14, + .bpp = 2, + }, { + .fourcc = V4L2_PIX_FMT_SGRBG14, + .mbus_code = MEDIA_BUS_FMT_SGRBG14_1X14, + .bpp = 2, + }, { + .fourcc = V4L2_PIX_FMT_SRGGB14, + .mbus_code = MEDIA_BUS_FMT_SRGGB14_1X14, + .bpp = 2, }, };
Fill in 10, 12, 14 bit Bayer formats into the DCMI driver. Those are useful e.g. when MT9P006 sensor is connected. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Alain Volmat <alain.volmat@foss.st.com> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Amelie DELAUNAY <amelie.delaunay@foss.st.com> Cc: Hugues FRUCHET <hugues.fruchet@foss.st.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Philippe CORNU <philippe.cornu@foss.st.com> Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org --- drivers/media/platform/st/stm32/stm32-dcmi.c | 48 ++++++++++++++++++++ 1 file changed, 48 insertions(+)