| Message ID | 20220609113148.3149194-1-dmitry.baryshkov@linaro.org |
|---|---|
| State | Accepted |
| Commit | a18a44e9262d5c7f7fbccbc9458df64d69185d41 |
| Headers | show |
| Series | drm/msm/hdmi: fill the pwr_regs bulk regulators | expand |
Quoting Dmitry Baryshkov (2022-06-09 04:31:48) > Conversion to use bulk regulator API omitted filling the pwr_regs with > proper regulator IDs. This was left unnoticed, since none of my testing > platforms has used the pwr_regs. Fix this by propagating regulator ids > properly. > > Fixes: 31b3b1f5e352 ("drm/msm/hdmi: use bulk regulator API") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index 992d29f75008..c66e857ef20e 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c @@ -180,6 +180,9 @@ static struct hdmi *msm_hdmi_init(struct platform_device *pdev) goto fail; } + for (i = 0; i < config->pwr_reg_cnt; i++) + hdmi->pwr_regs[i].supply = config->pwr_reg_names[i]; + ret = devm_regulator_bulk_get(&pdev->dev, config->pwr_reg_cnt, hdmi->pwr_regs); if (ret) { DRM_DEV_ERROR(&pdev->dev, "failed to get pwr regulator: %d\n", ret);
Conversion to use bulk regulator API omitted filling the pwr_regs with proper regulator IDs. This was left unnoticed, since none of my testing platforms has used the pwr_regs. Fix this by propagating regulator ids properly. Fixes: 31b3b1f5e352 ("drm/msm/hdmi: use bulk regulator API") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/hdmi/hdmi.c | 3 +++ 1 file changed, 3 insertions(+)