| Message ID | 20220608095623.22327-4-tmaimon77@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,01/20] clocksource: timer-npcm7xx: Add NPCM845 timer | expand |
Hi Arnd, Sorry but Just to clarify, This patch should not be applied and the NPCM8XX UART should use nuvoton,npcm750-uart compatible in the device tree? Because I thought that in your comment a few weeks ago https://www.spinics.net/lists/linux-serial/msg48179.html We need only to modify the compatible string in the device tree as we did in V2 patchset https://www.spinics.net/lists/arm-kernel/msg986480.html On Wed, 8 Jun 2022 at 15:01, Arnd Bergmann <arnd@arndb.de> wrote: > > On Wed, Jun 8, 2022 at 11:56 AM Tomer Maimon <tmaimon77@gmail.com> wrote: > > > > Add Nuvoton BMC NPCM845 UART support. > > The NPCM845 uses the same UART as the NPCM750. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > > This one should no longer be needed if the timers are compatible with the > old ones and correctly described in the DT. > > Arnd Thanks, Tomer
On Wed, Jun 8, 2022 at 3:40 PM Tomer Maimon <tmaimon77@gmail.com> wrote: > > Sorry but Just to clarify, This patch should not be applied and the > NPCM8XX UART should use nuvoton,npcm750-uart compatible in the device > tree? > > Because I thought that in your comment a few weeks ago > https://www.spinics.net/lists/linux-serial/msg48179.html > > We need only to modify the compatible string in the device tree as we > did in V2 patchset > https://www.spinics.net/lists/arm-kernel/msg986480.html Yes, this is correct: with the DT file from v2, the driver no longer needs to be changed, it will just match the fallback value. Arnd
diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c index 5a699a1aa79c..edf83c90b4d5 100644 --- a/drivers/tty/serial/8250/8250_of.c +++ b/drivers/tty/serial/8250/8250_of.c @@ -335,6 +335,7 @@ static const struct of_device_id of_platform_serial_table[] = { { .compatible = "ti,da830-uart", .data = (void *)PORT_DA830, }, { .compatible = "nuvoton,wpcm450-uart", .data = (void *)PORT_NPCM, }, { .compatible = "nuvoton,npcm750-uart", .data = (void *)PORT_NPCM, }, + { .compatible = "nuvoton,npcm845-uart", .data = (void *)PORT_NPCM, }, { /* end of list */ }, }; MODULE_DEVICE_TABLE(of, of_platform_serial_table);
Add Nuvoton BMC NPCM845 UART support. The NPCM845 uses the same UART as the NPCM750. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- drivers/tty/serial/8250/8250_of.c | 1 + 1 file changed, 1 insertion(+)