| Message ID | 20220606201343.514391-5-mail@conchuod.ie |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clear riscv dtbs_check errors | expand |
On 06/06/2022 21:13, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > After converting the pmic watchdog binding to yaml, dtbs_check complains > that the node name doesn't match the binding. "Fix" it. Hey Palmer, The three dt-binding changes were accepted - do I need to poke SiFive to ack the dts change or are you fine just taking it? Thanks, Conor. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > index c4ed9efdff03..1f386b07a832 100644 > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > @@ -90,7 +90,7 @@ rtc { > compatible = "dlg,da9063-rtc"; > }; > > - wdt { > + watchdog { > compatible = "dlg,da9063-watchdog"; > }; >
Am Montag, 13. Juni 2022, 15:33:49 CEST schrieb Conor.Dooley@microchip.com: > > On 06/06/2022 21:13, Conor Dooley wrote: > > From: Conor Dooley <conor.dooley@microchip.com> > > > > After converting the pmic watchdog binding to yaml, dtbs_check complains > > that the node name doesn't match the binding. "Fix" it. > > Hey Palmer, > The three dt-binding changes were accepted - do I need to poke SiFive to > ack the dts change or are you fine just taking it? I don't think a node-name has relevance to vendor decisions ;-) . Looking at bindings/watchdog/watchdog.yaml we clearly see that the node name is always watchdog or watchdog@foo, so this change is clearly correct. Reviewed-by: Heiko Stuebner <heiko@sntech.de> > Thanks, > Conor. > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > index c4ed9efdff03..1f386b07a832 100644 > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > @@ -90,7 +90,7 @@ rtc { > > compatible = "dlg,da9063-rtc"; > > }; > > > > - wdt { > > + watchdog { > > compatible = "dlg,da9063-watchdog"; > > }; > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv >
A ping and an offer: Palmer, do you want me to take the random dt cleanups through my tree & save you the hassle of following along with them? Thanks, Conor. On 13/06/2022 15:05, Heiko Stübner wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Am Montag, 13. Juni 2022, 15:33:49 CEST schrieb Conor.Dooley@microchip.com: >> >> On 06/06/2022 21:13, Conor Dooley wrote: >>> From: Conor Dooley <conor.dooley@microchip.com> >>> >>> After converting the pmic watchdog binding to yaml, dtbs_check complains >>> that the node name doesn't match the binding. "Fix" it. >> >> Hey Palmer, >> The three dt-binding changes were accepted - do I need to poke SiFive to >> ack the dts change or are you fine just taking it? > > I don't think a node-name has relevance to vendor decisions ;-) . > > Looking at bindings/watchdog/watchdog.yaml we clearly see that > the node name is always watchdog or watchdog@foo, so this change > is clearly correct. > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > >> Thanks, >> Conor. >> >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com> >>> --- >>> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts >>> index c4ed9efdff03..1f386b07a832 100644 >>> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts >>> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts >>> @@ -90,7 +90,7 @@ rtc { >>> compatible = "dlg,da9063-rtc"; >>> }; >>> >>> - wdt { >>> + watchdog { >>> compatible = "dlg,da9063-watchdog"; >>> }; >>> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv >> > > > >
On 27/06/2022 16:58, Conor.Dooley@microchip.com wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > A ping and an offer: > > Palmer, do you want me to take the random dt cleanups through > my tree & save you the hassle of following along with them? Since you declined that offer & nothing's been heard from the SiFive side since - I think this should also be good to take for 5.20. The bindings etc have already been applied. Thanks, Conor. > > Thanks, > Conor. > > On 13/06/2022 15:05, Heiko Stübner wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> Am Montag, 13. Juni 2022, 15:33:49 CEST schrieb Conor.Dooley@microchip.com: >>> >>> On 06/06/2022 21:13, Conor Dooley wrote: >>>> From: Conor Dooley <conor.dooley@microchip.com> >>>> >>>> After converting the pmic watchdog binding to yaml, dtbs_check complains >>>> that the node name doesn't match the binding. "Fix" it. >>> >>> Hey Palmer, >>> The three dt-binding changes were accepted - do I need to poke SiFive to >>> ack the dts change or are you fine just taking it? >> >> I don't think a node-name has relevance to vendor decisions ;-) . >> >> Looking at bindings/watchdog/watchdog.yaml we clearly see that >> the node name is always watchdog or watchdog@foo, so this change >> is clearly correct. >> >> Reviewed-by: Heiko Stuebner <heiko@sntech.de> >> >> >>> Thanks, >>> Conor. >>> >>>> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com> >>>> --- >>>> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts >>>> index c4ed9efdff03..1f386b07a832 100644 >>>> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts >>>> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts >>>> @@ -90,7 +90,7 @@ rtc { >>>> compatible = "dlg,da9063-rtc"; >>>> }; >>>> >>>> - wdt { >>>> + watchdog { >>>> compatible = "dlg,da9063-watchdog"; >>>> }; >>>> >>> _______________________________________________ >>> linux-riscv mailing list >>> linux-riscv@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-riscv >>> >> >> >> >> > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
On Mon, 06 Jun 2022 13:13:44 PDT (-0700), mail@conchuod.ie wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > After converting the pmic watchdog binding to yaml, dtbs_check complains > that the node name doesn't match the binding. "Fix" it. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > index c4ed9efdff03..1f386b07a832 100644 > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > @@ -90,7 +90,7 @@ rtc { > compatible = "dlg,da9063-rtc"; > }; > > - wdt { > + watchdog { > compatible = "dlg,da9063-watchdog"; > }; Thanks, this is on for-next.
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts index c4ed9efdff03..1f386b07a832 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -90,7 +90,7 @@ rtc { compatible = "dlg,da9063-rtc"; }; - wdt { + watchdog { compatible = "dlg,da9063-watchdog"; };