diff mbox series

[07/14] ARM: dts: qcom: msm8974: add required ranges to OCMEM

Message ID 20220607171848.535128-7-krzysztof.kozlowski@linaro.org
State Accepted
Commit 7a16ea7f3a5ec0f30b146b058c273b7a9c8ceadf
Headers show
Series [01/14] dt-bindings: sram: qcom,ocmem: cleanup example coding style | expand

Commit Message

Krzysztof Kozlowski June 7, 2022, 5:18 p.m. UTC
The OCMEM bindings require ranges property.

Fixes: a2cc991ed634 ("ARM: dts: qcom: msm8974: add ocmem node")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Not tested on HW. Testing might be useful.
---
 arch/arm/boot/dts/qcom-msm8974.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Luca Weiss June 10, 2022, 8:56 p.m. UTC | #1
Hi Krzysztof,

On Dienstag, 7. Juni 2022 19:18:41 CEST Krzysztof Kozlowski wrote:
> The OCMEM bindings require ranges property.
> 
> Fixes: a2cc991ed634 ("ARM: dts: qcom: msm8974: add ocmem node")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

No functional regression on fairphone-fp2. Thanks!

Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
Tested-by: Luca Weiss <luca@z3ntu.xyz>

> ---
> 
> Not tested on HW. Testing might be useful.
> ---
>  arch/arm/boot/dts/qcom-msm8974.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi
> b/arch/arm/boot/dts/qcom-msm8974.dtsi index 5e6b2ae72e62..add03309b3b4
> 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1608,6 +1608,7 @@ sram@fdd00000 {
>  			reg = <0xfdd00000 0x2000>,
>  			      <0xfec00000 0x180000>;
>  			reg-names = "ctrl", "mem";
> +			ranges = <0 0xfec00000 0x180000>;
>  			clocks = <&rpmcc RPM_SMD_OCMEMGX_CLK>,
>  				 <&mmcc OCMEMCX_OCMEMNOC_CLK>;
>  			clock-names = "core", "iface";
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index 5e6b2ae72e62..add03309b3b4 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -1608,6 +1608,7 @@  sram@fdd00000 {
 			reg = <0xfdd00000 0x2000>,
 			      <0xfec00000 0x180000>;
 			reg-names = "ctrl", "mem";
+			ranges = <0 0xfec00000 0x180000>;
 			clocks = <&rpmcc RPM_SMD_OCMEMGX_CLK>,
 				 <&mmcc OCMEMCX_OCMEMNOC_CLK>;
 			clock-names = "core", "iface";