| Message ID | 1654627965-1461-3-git-send-email-quic_vnivarth@quicinc.com |
|---|---|
| State | Accepted |
| Commit | 654a8d6c93e77ecff2256ca3ab2cd98967821f0a |
| Headers | show |
| Series | tty: serial: Introduce callback for start_rx and implement same for qcom-geni-serial | expand |
Hi, On Tue, Jun 7, 2022 at 11:53 AM Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> wrote: > > In suspend sequence stop_rx will be performed only if implementation for > start_rx callback is present. > > Set qcom_geni_serial_start_rx as callback for start_rx so that stop_rx is > performed. > > Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> > --- > drivers/tty/serial/qcom_geni_serial.c | 1 + > 1 file changed, 1 insertion(+) I think you also want a Fixes tag here, right? ...because if only the first patch is taken then it can actually regress Qualcomm devices. Thus: Fixes: c9d2325cdb92 ("serial: core: Do stop_rx in suspend path for console if console_suspend is disabled") Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 4733a23..f8f9506 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -1306,6 +1306,7 @@ static const struct uart_ops qcom_geni_console_pops = { .stop_tx = qcom_geni_serial_stop_tx, .start_tx = qcom_geni_serial_start_tx, .stop_rx = qcom_geni_serial_stop_rx, + .start_rx = qcom_geni_serial_start_rx, .set_termios = qcom_geni_serial_set_termios, .startup = qcom_geni_serial_startup, .request_port = qcom_geni_serial_request_port,
In suspend sequence stop_rx will be performed only if implementation for start_rx callback is present. Set qcom_geni_serial_start_rx as callback for start_rx so that stop_rx is performed. Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> --- drivers/tty/serial/qcom_geni_serial.c | 1 + 1 file changed, 1 insertion(+)