diff mbox

[09/19] mfd: arizona-core: msleep() is unreliable for anything <20ms use usleep_range() instead

Message ID 1449489032-14374-10-git-send-email-lee.jones@linaro.org
State New
Headers show

Commit Message

Lee Jones Dec. 7, 2015, 11:50 a.m. UTC
WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
+               msleep(1);

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
+                       msleep(5);

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
+               msleep(1);

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
+               msleep(1);

total: 0 errors, 4 warnings, 1407 lines checked

Cc: patches@opensource.wolfsonmicro.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/mfd/arizona-core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

Lee Jones Dec. 8, 2015, 3:45 p.m. UTC | #1
On Tue, 08 Dec 2015, Charles Keepax wrote:

> On Mon, Dec 07, 2015 at 11:50:22AM +0000, Lee Jones wrote:

> > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt

> > +               msleep(1);

> > 

> > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt

> > +                       msleep(5);

> > 

> > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt

> > +               msleep(1);

> > 

> > WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt

> > +               msleep(1);

> > 

> > total: 0 errors, 4 warnings, 1407 lines checked

> > 

> > Cc: patches@opensource.wolfsonmicro.com

> > Signed-off-by: Lee Jones <lee.jones@linaro.org>

> > ---

> 

> This doesn't actually appear to cc patches. But all looks good:


That's odd.  I have no overrides in place and --[no-]signed-off-by-cc
should default to --signed-off-by-cc.
> 

> Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>


Ta

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
diff mbox

Patch

diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 44cfdbb..ceba17ca 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -239,7 +239,7 @@  static int arizona_poll_reg(struct arizona *arizona,
 		if ((val & mask) == target)
 			return 0;
 
-		msleep(1);
+		usleep_range(1000, 5000);
 	}
 
 	dev_err(arizona->dev, "Polling reg %u timed out: %x\n", reg, val);
@@ -280,14 +280,14 @@  static void arizona_disable_reset(struct arizona *arizona)
 		case WM5110:
 		case WM8280:
 			/* Meet requirements for minimum reset duration */
-			msleep(5);
+			usleep_range(5000, 10000);
 			break;
 		default:
 			break;
 		}
 
 		gpio_set_value_cansleep(arizona->pdata.reset, 1);
-		msleep(1);
+		usleep_range(1000, 5000);
 	}
 }
 
@@ -1045,7 +1045,7 @@  int arizona_dev_init(struct arizona *arizona)
 			goto err_reset;
 		}
 
-		msleep(1);
+		usleep_range(1000, 5000);
 	}
 
 	/* Ensure device startup is complete */