diff mbox series

[10/10] scsi/lpfc: Remove bogus references to discovery tasklet

Message ID 20220530231512.9729-11-dave@stgolabs.net
State New
Headers show
Series scsi: Replace tasklets as BH | expand

Commit Message

Davidlohr Bueso May 30, 2022, 11:15 p.m. UTC
This is done as thread. Also remove an unused member of the
lpfc_vport structure.

Cc: James Smart <james.smart@broadcom.com>
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
---
 drivers/scsi/lpfc/lpfc.h      | 2 --
 drivers/scsi/lpfc/lpfc_disc.h | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

Comments

Sebastian Andrzej Siewior June 9, 2022, 3:21 p.m. UTC | #1
On 2022-05-30 16:15:12 [-0700], Davidlohr Bueso wrote:
> This is done as thread. Also remove an unused member of the
> lpfc_vport structure.

As per Documentation/scsi/ChangeLog.lpfc the tasklet usage was removed
in "20040515 to 20040526" and the driver was merged in 2005. It was
never used in the kernel.
Nice.

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Sebastian
diff mbox series

Patch

diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h
index da9070cdad91..05da8ccb0933 100644
--- a/drivers/scsi/lpfc/lpfc.h
+++ b/drivers/scsi/lpfc/lpfc.h
@@ -645,8 +645,6 @@  struct lpfc_vport {
 	struct lpfc_name fc_nodename;	/* fc nodename */
 	struct lpfc_name fc_portname;	/* fc portname */
 
-	struct lpfc_work_evt disc_timeout_evt;
-
 	struct timer_list fc_disctmo;	/* Discovery rescue timer */
 	uint8_t fc_ns_retry;	/* retries for fabric nameserver */
 	uint32_t fc_prli_sent;	/* cntr for outstanding PRLIs */
diff --git a/drivers/scsi/lpfc/lpfc_disc.h b/drivers/scsi/lpfc/lpfc_disc.h
index 37a4b79010bf..40f458ee1aec 100644
--- a/drivers/scsi/lpfc/lpfc_disc.h
+++ b/drivers/scsi/lpfc/lpfc_disc.h
@@ -44,7 +44,7 @@  enum lpfc_work_type {
 	LPFC_EVT_RECOVER_PORT
 };
 
-/* structure used to queue event to the discovery tasklet */
+/* structure used to queue event to the discovery thread */
 struct lpfc_work_evt {
 	struct list_head      evt_listp;
 	void                 *evt_arg1;