| Message ID | 20220525165852.33167-3-eajames@linux.ibm.com |
|---|---|
| State | Accepted |
| Commit | ebf2a3521738520e12849b221fea24928b3f61ff |
| Headers | show |
| Series | spi: fsi: Fix spurious timeout | expand |
Hello, On Wed, May 25, 2022 at 11:58:52AM -0500, Eddie James wrote: > All the other calls to the controller driver display the error > return code. The return code is helpful to understand what went > wrong, so include it when failing to transfer one message. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> > --- > drivers/spi/spi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 481edea77c62..ea09d1b42bf6 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1654,7 +1654,8 @@ static void __spi_pump_messages(struct spi_controller *ctlr, bool in_kthread) > ret = ctlr->transfer_one_message(ctlr, msg); > if (ret) { > dev_err(&ctlr->dev, > - "failed to transfer one message from queue\n"); > + "failed to transfer one message from queue: %d\n", > + ret); (I know it's too late, just stumbled over this commit in mainline by chance. So maybe just a suggestion for the next similar change...) A tad nicer would be to use %pe instead of %d that results in mydev mybus: failed to transfer one message from queue: -EIO instead of mydev mybus: failed to transfer one message from queue: -5 and so is more descriptive. (Note you need ERR_PTR(ret) for %pe.) Best regards Uwe
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 481edea77c62..ea09d1b42bf6 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1654,7 +1654,8 @@ static void __spi_pump_messages(struct spi_controller *ctlr, bool in_kthread) ret = ctlr->transfer_one_message(ctlr, msg); if (ret) { dev_err(&ctlr->dev, - "failed to transfer one message from queue\n"); + "failed to transfer one message from queue: %d\n", + ret); goto out; }
All the other calls to the controller driver display the error return code. The return code is helpful to understand what went wrong, so include it when failing to transfer one message. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- drivers/spi/spi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)