diff mbox

[API-NEXT/PATCHv4,1/4] api: classification: add odp_cls_cos_pool_set() api

Message ID 1449139566-1196-1-git-send-email-bala.manoharan@linaro.org
State Accepted
Commit 8cf523f1f5b7280386f6c4c4d2bf9a68619aef1c
Headers show

Commit Message

Balasubramanian Manoharan Dec. 3, 2015, 10:46 a.m. UTC
odp_cls_cos_pool_set() api is used to configure packet pool to CoS.
The packets arriving at the CoS is allocated from the configured pool

Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
---
v4: Adds detailed api description

v3: Test Cases added to test pools associated with CoS

v2: Incorporates review comments from Stuart
 include/odp/api/classification.h | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Comments

Bill Fischofer Dec. 4, 2015, 3:29 a.m. UTC | #1
On Thu, Dec 3, 2015 at 5:22 AM, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolainen@nokia.com> wrote:

>

> Couple of small things still, with those fixed:

>

> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>

>

>

>

>

> > -----Original Message-----

> > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of EXT

> > Balasubramanian Manoharan

> > Sent: Thursday, December 03, 2015 12:46 PM

> > To: lng-odp@lists.linaro.org

> > Subject: [lng-odp] [API-NEXT/PATCHv4 1/4] api: classification: add

> > odp_cls_cos_pool_set() api

> >

> > odp_cls_cos_pool_set() api is used to configure packet pool to CoS.

> > The packets arriving at the CoS is allocated from the configured pool

> >

> > Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>

>


Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org>


> > ---

> > v4: Adds detailed api description

> >

> > v3: Test Cases added to test pools associated with CoS

> >

> > v2: Incorporates review comments from Stuart

> >  include/odp/api/classification.h | 27 +++++++++++++++++++++++++++

> >  1 file changed, 27 insertions(+)

> >

> > diff --git a/include/odp/api/classification.h

> > b/include/odp/api/classification.h

> > index 380d91b..5db7661 100644

> > --- a/include/odp/api/classification.h

> > +++ b/include/odp/api/classification.h

> > @@ -379,6 +379,33 @@ int odp_pktio_pmr_match_set_cos(odp_pmr_set_t

> > pmr_set_id, odp_pktio_t src_pktio,

> >                               odp_cos_t dst_cos);

> >

> >  /**

> > +* Assigns a packet pool for a specific class of service.

> > +* All the packets belonging to the given class of service will

> > +* be allocated from the assigned packet pool.

> > +* The packet pool associated with class of service will supersede the

> > +* packet pool associated with the pktio interface.

> > +*

> > +* @param     cos_id  class of service handle

> > +* @param     pool_id Packet buffer pool handle

>

> Packet pool...

>

> > +*

> > +* @retval    0 on success

> > +* @retval    <0 on failure

> > +*/

> > +int odp_cls_cos_pool_set(odp_cos_t cos_id, odp_pool_t pool_id);

> > +

> > +/**

> > +* Get the pool associated with the given class of service

> > +*

> > +* @param     cos_id  class of service handle

> > +*

> > +* @retval    pool handle of the associated pool

> > +* @retval    ODP_POOL_INVALID if no associated pool found or

> > +             incase of an error

> > +*

>

> Error in line feed above: * missing and extra empty line

>

>

> > +*/

> > +odp_pool_t odp_cls_cos_pool(odp_cos_t cos_id);

> > +

> > +/**

> >   * Get printable value for an odp_cos_t

> >   *

> >   * @param hdl  odp_cos_t handle to be printed

> > --

> > 1.9.1

> >

> > _______________________________________________

> > lng-odp mailing list

> > lng-odp@lists.linaro.org

> > https://lists.linaro.org/mailman/listinfo/lng-odp

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp

>
Maxim Uvarov Dec. 7, 2015, 9:14 a.m. UTC | #2
Merged.
Maxim.

On 12/04/2015 06:29, Bill Fischofer wrote:
>
>
> On Thu, Dec 3, 2015 at 5:22 AM, Savolainen, Petri (Nokia - FI/Espoo) 
> <petri.savolainen@nokia.com <mailto:petri.savolainen@nokia.com>> wrote:
>
>
>     Couple of small things still, with those fixed:
>
>     Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com
>     <mailto:petri.savolainen@nokia.com>>
>
>
>
>
>     > -----Original Message-----
>     > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org
>     <mailto:lng-odp-bounces@lists.linaro.org>] On Behalf Of EXT
>     > Balasubramanian Manoharan
>     > Sent: Thursday, December 03, 2015 12:46 PM
>     > To: lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     > Subject: [lng-odp] [API-NEXT/PATCHv4 1/4] api: classification: add
>     > odp_cls_cos_pool_set() api
>     >
>     > odp_cls_cos_pool_set() api is used to configure packet pool to CoS.
>     > The packets arriving at the CoS is allocated from the configured
>     pool
>     >
>     > Signed-off-by: Balasubramanian Manoharan
>     <bala.manoharan@linaro.org <mailto:bala.manoharan@linaro.org>>
>
>
> Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org 
> <mailto:bill.fischofer@linaro.org>>
>
>     > ---
>     > v4: Adds detailed api description
>     >
>     > v3: Test Cases added to test pools associated with CoS
>     >
>     > v2: Incorporates review comments from Stuart
>     >  include/odp/api/classification.h | 27 +++++++++++++++++++++++++++
>     >  1 file changed, 27 insertions(+)
>     >
>     > diff --git a/include/odp/api/classification.h
>     > b/include/odp/api/classification.h
>     > index 380d91b..5db7661 100644
>     > --- a/include/odp/api/classification.h
>     > +++ b/include/odp/api/classification.h
>     > @@ -379,6 +379,33 @@ int odp_pktio_pmr_match_set_cos(odp_pmr_set_t
>     > pmr_set_id, odp_pktio_t src_pktio,
>     >                               odp_cos_t dst_cos);
>     >
>     >  /**
>     > +* Assigns a packet pool for a specific class of service.
>     > +* All the packets belonging to the given class of service will
>     > +* be allocated from the assigned packet pool.
>     > +* The packet pool associated with class of service will
>     supersede the
>     > +* packet pool associated with the pktio interface.
>     > +*
>     > +* @param     cos_id  class of service handle
>     > +* @param     pool_id Packet buffer pool handle
>
>     Packet pool...
>
>     > +*
>     > +* @retval    0 on success
>     > +* @retval    <0 on failure
>     > +*/
>     > +int odp_cls_cos_pool_set(odp_cos_t cos_id, odp_pool_t pool_id);
>     > +
>     > +/**
>     > +* Get the pool associated with the given class of service
>     > +*
>     > +* @param     cos_id  class of service handle
>     > +*
>     > +* @retval    pool handle of the associated pool
>     > +* @retval    ODP_POOL_INVALID if no associated pool found or
>     > +             incase of an error
>     > +*
>
>     Error in line feed above: * missing and extra empty line
>
>
>     > +*/
>     > +odp_pool_t odp_cls_cos_pool(odp_cos_t cos_id);
>     > +
>     > +/**
>     >   * Get printable value for an odp_cos_t
>     >   *
>     >   * @param hdl  odp_cos_t handle to be printed
>     > --
>     > 1.9.1
>     >
>     > _______________________________________________
>     > lng-odp mailing list
>     > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     > https://lists.linaro.org/mailman/listinfo/lng-odp
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/include/odp/api/classification.h b/include/odp/api/classification.h
index 380d91b..5db7661 100644
--- a/include/odp/api/classification.h
+++ b/include/odp/api/classification.h
@@ -379,6 +379,33 @@  int odp_pktio_pmr_match_set_cos(odp_pmr_set_t pmr_set_id, odp_pktio_t src_pktio,
 				odp_cos_t dst_cos);
 
 /**
+* Assigns a packet pool for a specific class of service.
+* All the packets belonging to the given class of service will
+* be allocated from the assigned packet pool.
+* The packet pool associated with class of service will supersede the
+* packet pool associated with the pktio interface.
+*
+* @param	cos_id	class of service handle
+* @param	pool_id	Packet buffer pool handle
+*
+* @retval	0 on success
+* @retval	<0 on failure
+*/
+int odp_cls_cos_pool_set(odp_cos_t cos_id, odp_pool_t pool_id);
+
+/**
+* Get the pool associated with the given class of service
+*
+* @param	cos_id	class of service handle
+*
+* @retval	pool handle of the associated pool
+* @retval	ODP_POOL_INVALID if no associated pool found or
+		incase of an error
+*
+*/
+odp_pool_t odp_cls_cos_pool(odp_cos_t cos_id);
+
+/**
  * Get printable value for an odp_cos_t
  *
  * @param hdl  odp_cos_t handle to be printed