| Message ID | 20220523144255.10310-1-linmq006@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: sdhci-of-esdhc: Fix refcount leak in esdhc_signal_voltage_switch | expand |
On Mon, 23 May 2022 at 16:43, Miaoqian Lin <linmq006@gmail.com> wrote: > > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > of_node_put() checks null pointer. > > Fixes: ea35645a3c66 ("mmc: sdhci-of-esdhc: add support for signal voltage switch") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Queued for v5.20 on the devel branch, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-esdhc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c > index d9dc41143bb3..8b3d8119f388 100644 > --- a/drivers/mmc/host/sdhci-of-esdhc.c > +++ b/drivers/mmc/host/sdhci-of-esdhc.c > @@ -904,6 +904,7 @@ static int esdhc_signal_voltage_switch(struct mmc_host *mmc, > scfg_node = of_find_matching_node(NULL, scfg_device_ids); > if (scfg_node) > scfg_base = of_iomap(scfg_node, 0); > + of_node_put(scfg_node); > if (scfg_base) { > sdhciovselcr = SDHCIOVSELCR_TGLEN | > SDHCIOVSELCR_VSELVAL; > -- > 2.25.1 >
diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index d9dc41143bb3..8b3d8119f388 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -904,6 +904,7 @@ static int esdhc_signal_voltage_switch(struct mmc_host *mmc, scfg_node = of_find_matching_node(NULL, scfg_device_ids); if (scfg_node) scfg_base = of_iomap(scfg_node, 0); + of_node_put(scfg_node); if (scfg_base) { sdhciovselcr = SDHCIOVSELCR_TGLEN | SDHCIOVSELCR_VSELVAL;
of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. of_node_put() checks null pointer. Fixes: ea35645a3c66 ("mmc: sdhci-of-esdhc: add support for signal voltage switch") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/mmc/host/sdhci-of-esdhc.c | 1 + 1 file changed, 1 insertion(+)