diff mbox

[v2] uselib: default depending if libc5 was used

Message ID 1448622860-9689-1-git-send-email-riku.voipio@linaro.org
State Superseded
Headers show

Commit Message

Riku Voipio Nov. 27, 2015, 11:14 a.m. UTC
uselib hasn't been used since libc5; glibc does not use it.
Deprecate uselib a bit more, by making the default y only
if libc5 was widely used on the plaform.

This makes arm64 kernel built with defconfig slighly smaller

bloat-o-meter:
add/remove: 0/3 grow/shrink: 0/2 up/down: 0/-1390 (-1390)
function                                     old     new   delta
kernel_config_data                         18164   18162      -2
uselib_flags                                  20       -     -20
padzero                                      216     192     -24
sys_uselib                                   380       -    -380
load_elf_library                             964       -    -964

Signed-off-by: Riku Voipio <riku.voipio@linaro.org>

Cc: Josh Triplett <josh@joshtriplett.org>
---
v2: Disable on X86_64 if no 32bit support
 init/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

Riku Voipio Dec. 1, 2015, 12:35 p.m. UTC | #1
On 1 December 2015 at 10:46, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, Dec 1, 2015 at 1:31 AM, Andrew Morton <akpm@linux-foundation.org> wrote:

>> On Fri, 27 Nov 2015 12:07:10 -0800 Josh Triplett <josh@joshtriplett.org> wrote:

>>> IA32_EMULATION depends on X86_64, so doesn't that reduce to:

>>>       def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION


Ok. looks cleaner to me.

>> It's a bit old fashioned to add an expression like this at the

>> definition site anyway.  The cool new thing is to do

>>

>>         def_bool ARCH_WANT_USELIB

>>

>> then go off and define ARCH_WANT_USELIB in the appropriate places in

>> the per-arch Kconfig files.

>

> That's useful for new to-be-implemented features, but this dependency list is

> (hopefully) cast in stone. No new architecture should need this.

> So I see no reason to clutter up more Kconfig files.


I agree. Splitting oneline patch to a patch that changes 5 files around kernel
tree only risks merge conflicts in this case.

Riku
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
diff mbox

Patch

diff --git a/init/Kconfig b/init/Kconfig
index c24b6f7..a4bc657 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -285,7 +285,7 @@  config FHANDLE
 
 config USELIB
 	bool "uselib syscall"
-	default y
+	def_bool ALPHA || M68K || SPARC || X86_32 || (X86_64 && IA32_EMULATION)
 	help
 	  This option enables the uselib syscall, a system call used in the
 	  dynamic linker from libc5 and earlier.  glibc does not use this