| Message ID | 20220512191352.15602-2-dylan.laduranty@mesotic.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2,v2] ASoC: ADAU7118: add bindings for managing pins drive strength | expand |
> -----Original Message----- > From: Dylan Laduranty <dylan.laduranty@mesotic.com> > Sent: Thursday, May 12, 2022 9:14 PM > To: alsa-devel@alsa-project.org > Cc: Sa, Nuno <Nuno.Sa@analog.com>; Dylan Laduranty > <dylan.laduranty@mesotic.com> > Subject: [PATCH 2/2] dt-bindings: ADAU7118: add new entries for pins > drive strength > > [External] > > Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com> > --- > checkpatch will complain about not having a commit message. With that fixed: Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Le vendredi 13 mai 2022, 09:08:13 CEST Sa, Nuno a écrit : > > -----Original Message----- > > From: Dylan Laduranty <dylan.laduranty@mesotic.com> > > Sent: Thursday, May 12, 2022 9:14 PM > > To: alsa-devel@alsa-project.org > > Cc: Sa, Nuno <Nuno.Sa@analog.com>; Dylan Laduranty > > <dylan.laduranty@mesotic.com> > > Subject: [PATCH 2/2] dt-bindings: ADAU7118: add new entries for pins > > drive strength > > > > [External] > > > > Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com> > > --- > > checkpatch will complain about not having a commit message. > With that fixed: Oops sorry about that. Should I resend a V2 with a proper commit message for this patch (or both patches ?) Or maybe prepare a V3 with more description (and a commit message for this one) ? > > Reviewed-by: Nuno Sá <nuno.sa@analog.com> Dylan Laduranty
> -----Original Message----- > From: Dylan Laduranty <dylan.laduranty@mesotic.com> > Sent: Friday, May 13, 2022 9:15 AM > To: Sa, Nuno <Nuno.Sa@analog.com> > Cc: alsa-devel@alsa-project.org > Subject: Re: [PATCH 2/2] dt-bindings: ADAU7118: add new entries for > pins drive strength > > [External] > > Le vendredi 13 mai 2022, 09:08:13 CEST Sa, Nuno a écrit : > > > -----Original Message----- > > > From: Dylan Laduranty <dylan.laduranty@mesotic.com> > > > Sent: Thursday, May 12, 2022 9:14 PM > > > To: alsa-devel@alsa-project.org > > > Cc: Sa, Nuno <Nuno.Sa@analog.com>; Dylan Laduranty > > > <dylan.laduranty@mesotic.com> > > > Subject: [PATCH 2/2] dt-bindings: ADAU7118: add new entries for > pins > > > drive strength > > > > > > [External] > > > > > > Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com> > > > --- > > > > checkpatch will complain about not having a commit message. > > With that fixed: > > Oops sorry about that. Should I resend a V2 with a proper commit > message for > this patch (or both patches ?) Or maybe prepare a V3 with more > description > (and a commit message for this one) ? Well, I think you should have been marked these patches as v2 already :). Anyways, I'm not sure but I would say you should send a v3 with the changes in the messages and make sure to keep checkpatch happy. - Nuno Sá
diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml index fb78967ee17b..226693ebd446 100644 --- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml +++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml @@ -51,6 +51,42 @@ properties: maximum: 1 default: [0, 0, 1, 1] + adi,pdm-clk0-ds: + description: | + This property set the drive strength of PDM CLK0 output pad. + Possible values are: 0, 1, 2, 3 as per the following table: + 0 = 2.5 mA / 3.3V + 1 = 5 mA / 3.3V + 2 = 10 mA / 3.3V + 3 = 25 mA / 3.3V + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [3, 2, 1, 0] + default: 2 + + adi,pdm-clk1-ds: + description: | + This property set the drive strength of PDM CLK1 output pad. + Possible values are: 0, 1, 2, 3 as per the following table: + 0 = 2.5 mA / 3.3V + 1 = 5 mA / 3.3V + 2 = 10 mA / 3.3V + 3 = 25 mA / 3.3V + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [3, 2, 1, 0] + default: 2 + + adi,sdata-ds: + description: | + This property set the drive strength of SDATA output pad. + Possible values are: 0, 1, 2, 3 as per the following table: + 0 = 2.5 mA / 3.3V + 1 = 5 mA / 3.3V + 2 = 10 mA / 3.3V + 3 = 25 mA / 3.3V + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [3, 2, 1, 0] + default: 2 + required: - "#sound-dai-cells" - compatible @@ -73,6 +109,9 @@ examples: dvdd-supply = <&supply>; adi,pdm-clk-map = <1 1 0 0>; adi,decimation-ratio = <16>; + adi,pdm-clk0-ds = <3>; + adi,pdm-clk1-ds = <3>; + adi,sdata-ds = <3>; }; };
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com> --- Changes since v1: Add description values table per new entries .../bindings/sound/adi,adau7118.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+)