diff mbox

[v2] cpufreq: scpi: Depend on SCPI clk driver

Message ID 1447854764-9865-1-git-send-email-punit.agrawal@arm.com
State New
Headers show

Commit Message

Punit Agrawal Nov. 18, 2015, 1:52 p.m. UTC
The SCPI clk driver registers the virtual cpufreq device that kicks off
initialisation of the SCPI cpufreq driver. Also, clk_get() will fail for
the cpufreq driver if the scpi clk driver is missing.

Fix this by making the scpi cpufreq driver explicitly depend on the scpi
clk driver.

Fixes: 8def31034d03 ("cpufreq: arm_big_little: add SCPI interface driver")
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>

Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/Kconfig.arm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Viresh Kumar Nov. 18, 2015, 2:05 p.m. UTC | #1
On 18-11-15, 13:52, Punit Agrawal wrote:
> The SCPI clk driver registers the virtual cpufreq device that kicks off

> initialisation of the SCPI cpufreq driver. Also, clk_get() will fail for

> the cpufreq driver if the scpi clk driver is missing.

> 

> Fix this by making the scpi cpufreq driver explicitly depend on the scpi

> clk driver.

> 

> Fixes: 8def31034d03 ("cpufreq: arm_big_little: add SCPI interface driver")

> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>

> Cc: Sudeep Holla <sudeep.holla@arm.com>

> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>

> Cc: Viresh Kumar <viresh.kumar@linaro.org>

> ---

>  drivers/cpufreq/Kconfig.arm | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm

> index 1582c1c..dadfdd4 100644

> --- a/drivers/cpufreq/Kconfig.arm

> +++ b/drivers/cpufreq/Kconfig.arm

> @@ -201,7 +201,7 @@ config ARM_SA1110_CPUFREQ

>  

>  config ARM_SCPI_CPUFREQ

>          tristate "SCPI based CPUfreq driver"

> -	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL

> +	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI

>          help

>  	  This adds the CPUfreq driver support for ARM big.LITTLE platforms

>  	  using SCPI protocol for CPU power management.


Acked-by: Viresh Kumar <viresh.kumar@linaro.org>


-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 1582c1c..dadfdd4 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -201,7 +201,7 @@  config ARM_SA1110_CPUFREQ
 
 config ARM_SCPI_CPUFREQ
         tristate "SCPI based CPUfreq driver"
-	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL
+	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
         help
 	  This adds the CPUfreq driver support for ARM big.LITTLE platforms
 	  using SCPI protocol for CPU power management.