diff mbox series

[v2,1/2] dt-bindings: iio: sx9324: Add CS idle/sleep mode

Message ID 20220503193937.3794477-2-swboyd@chromium.org
State Accepted
Commit f24333103e844d479161f8d58d59afa2ceac729b
Headers show
Series [v2,1/2] dt-bindings: iio: sx9324: Add CS idle/sleep mode | expand

Commit Message

Stephen Boyd May 3, 2022, 7:39 p.m. UTC 
We need to configure the sleep and idle mode of the CS pins for this
device. Add a DT property to do this so pins are in a proper state
during sleep (either hi-z, grounded, or pulled up to vdd).

Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 .../bindings/iio/proximity/semtech,sx9324.yaml           | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Rob Herring May 9, 2022, 9:39 p.m. UTC | #1 
On Wed, May 04, 2022 at 05:15:55PM +0200, Krzysztof Kozlowski wrote:
> On 04/05/2022 17:03, Rob Herring wrote:
> >>>  
> >>> +  semtech,cs-idle-sleep:
> >>> +    description:
> >>> +      State of CS pins during sleep mode and idle time.
> >>> +    enum:
> >>> +      - hi-z
> >>> +      - gnd
> >>> +      - vdd
> >>
> >> You need a ref to type (string).
> > 
> > Actually, it can be implicit for single strings.
> 
> Is this a generic preference?

I don't have a preference, just noting that both are allowed. I like 
having a smaller schema, but then it is a bit of a special case.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
index d265eb5258c8..b3aa2ebf9661 100644
--- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
+++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
@@ -126,6 +126,14 @@  properties:
       UINT_MAX (4294967295) represents infinite. Other values
       represent 1-1/N.
 
+  semtech,cs-idle-sleep:
+    description:
+      State of CS pins during sleep mode and idle time.
+    enum:
+      - hi-z
+      - gnd
+      - vdd
+
   semtech,int-comp-resistor:
     description:
       Internal resistor setting for compensation.
@@ -187,5 +195,6 @@  examples:
         semtech,avg-pos-strength = <64>;
         semtech,int-comp-resistor = "lowest";
         semtech,input-precharge-resistor-ohms = <2000>;
+        semtech,cs-idle-sleep = "gnd";
       };
     };