| Message ID | 20220421192132.109954-7-nick.hawkins@hpe.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On 21/04/2022 21:21, nick.hawkins@hpe.com wrote: > --- > .../bindings/watchdog/hpe,gxp-wdt.yaml | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml > new file mode 100644 > index 000000000000..c20da146352f > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml > @@ -0,0 +1,30 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/hpe,gxp-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP Controlled Watchdog > + > +allOf: > + - $ref: "watchdog.yaml#" allOf goes after maintainers, before properties. > + > +maintainers: > + - Nick Hawkins <nick.hawkins@hpe.com> > + - Jean-Marie Verdun <verdun@hpe.com> > + > +properties: > + compatible: > + const: hpe,gxp-wdt > + > +required: > + - compatible > + > +unevaluatedProperties: false > + > +examples: > + - | > + watchdog0: watchdog { Doubled space. > + compatible = "hpe,gxp-wdt"; > + }; > + Best regards, Krzysztof
-----Original Message----- From: Rob Herring [mailto:robh@kernel.org] Sent: Monday, April 25, 2022 5:05 PM To: Hawkins, Nick <nick.hawkins@hpe.com> Cc: Verdun, Jean-Marie <verdun@hpe.com>; joel@jms.id.au; arnd@arndb.de; openbmc@lists.ozlabs.org; Wim Van Sebroeck <wim@linux-watchdog.org>; Guenter Roeck <linux@roeck-us.net>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; linux-watchdog@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding (...) > How is this h/w controlled? I'm guessing it's part of the timer? If so, you don't need this node. A single node can implement multiple functions. It is associated with the timer because of the shared register set. Based on feedback from Krzysztof I need to create a child node for gxp-timer. I therefore will remove this file and move gxp-wdt to the hpe,gxp-timer.yaml as a child node. Thank you for the feedback. -Nick Hawkins
diff --git a/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml new file mode 100644 index 000000000000..c20da146352f --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml @@ -0,0 +1,30 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/hpe,gxp-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HPE GXP Controlled Watchdog + +allOf: + - $ref: "watchdog.yaml#" + +maintainers: + - Nick Hawkins <nick.hawkins@hpe.com> + - Jean-Marie Verdun <verdun@hpe.com> + +properties: + compatible: + const: hpe,gxp-wdt + +required: + - compatible + +unevaluatedProperties: false + +examples: + - | + watchdog0: watchdog { + compatible = "hpe,gxp-wdt"; + }; +