| Message ID | 20220414084040.975520-1-paul.kocialkowski@bootlin.com |
|---|---|
| State | Accepted |
| Commit | 73f93db5c49b9f52c902e5dc6c750bf9832e0450 |
| Headers | show |
| Series | spi: core: Initialize returned status in spi_setup | expand |
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 563a56ce34a0..890ff46c784a 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -3475,7 +3475,7 @@ static int __spi_validate_bits_per_word(struct spi_controller *ctlr, int spi_setup(struct spi_device *spi) { unsigned bad_bits, ugly_bits; - int status; + int status = 0; /* * Check mode to prevent that any two of DUAL, QUAD and NO_MOSI/MISO
The previous commit that made bits-per-word validation conditional results in leaving no unconditional affectation of the status variable. Since the variable is returned at the end of the function, initialize it to avoid returning an undefined value. Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Fixes: b3fe2e516741 ("spi: core: Only check bits_per_word validity when explicitly provided") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/spi/spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)