| Message ID | 1446730488-31930-3-git-send-email-puck.chen@hisilicon.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Nov 05, 2015 at 09:34:43PM +0800, Chen Feng wrote: > +- hisilicon,mtcmos-steady-us: The time to wait for power steady > +- hisilicon,mtcmos-sc-on-base: address of mtcmos on hi6220 SoC > + > +Required child device properties: > +- regulator-name: The name of mtcmos > +- hisilicon,ctrl-regs: Offset of ctrl-regs > +- hisilicon,ctrl-data: The bit to ctrl the regulator This doesn't look like a regulator binding at all... for one thing there's no reference to the generic regulator bindings, and having a mandatory regulator-name seems like there's a problem somewhere.
On Thu, Nov 05, 2015 at 09:34:43PM +0800, Chen Feng wrote: > Add Document for mtcmos driver on hi6220 SoC > > Signed-off-by: Chen Feng <puck.chen@hisilicon.com> > Signed-off-by: Fei Wang <w.f@huawei.com> > --- > .../bindings/regulator/hisilicon,hi6220-mtcmos.txt | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt > > diff --git a/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt > new file mode 100644 > index 0000000..bb06e1b > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt > @@ -0,0 +1,32 @@ > +Hi6220 mtcmos Voltage regulators > + > +Required parent device properties: > +- compatible: Must be "hisilicon,hi6220-mtcmos-driver" What does "driver" refer to? > +- hisilicon,mtcmos-steady-us: The time to wait for power steady Wouldn't regulator-enable-ramp-delay be equivalent? > +- hisilicon,mtcmos-sc-on-base: address of mtcmos on hi6220 SoC > + > +Required child device properties: > +- regulator-name: The name of mtcmos > +- hisilicon,ctrl-regs: Offset of ctrl-regs > +- hisilicon,ctrl-data: The bit to ctrl the regulator > + > +Example: > + mtcmos { > + compatible = "hisilicon,hi6220-mtcmos-driver"; > + hisilicon,mtcmos-steady-us = <10>; > + hisilicon,mtcmos-sc-on-base = <0xf7800000>; > + hisilicon,mtcmos-acpu-on-base = <0xf65a0000>; > + > + mtcmos1: regulator@a1{ > + regulator-name = "G3D_PD_VDD"; > + regulator-compatible = "mtcmos1"; regulator-compatible is deprecated. Please drop. > + hisilicon,ctrl-regs = <0x830 0x834 0x83c>; > + hisilicon,ctrl-data = <1 0x1>; > + }; > + mtcmos2: regulator@a2{ > + regulator-name = "SOC_MED"; > + regulator-compatible = "mtcmos2"; > + hisilicon,ctrl-regs = <0x830 0x834 0x83c>; > + hisilicon,ctrl-data = <2 0x1>; > + }; > + }; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt new file mode 100644 index 0000000..bb06e1b --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt @@ -0,0 +1,32 @@ +Hi6220 mtcmos Voltage regulators + +Required parent device properties: +- compatible: Must be "hisilicon,hi6220-mtcmos-driver" +- hisilicon,mtcmos-steady-us: The time to wait for power steady +- hisilicon,mtcmos-sc-on-base: address of mtcmos on hi6220 SoC + +Required child device properties: +- regulator-name: The name of mtcmos +- hisilicon,ctrl-regs: Offset of ctrl-regs +- hisilicon,ctrl-data: The bit to ctrl the regulator + +Example: + mtcmos { + compatible = "hisilicon,hi6220-mtcmos-driver"; + hisilicon,mtcmos-steady-us = <10>; + hisilicon,mtcmos-sc-on-base = <0xf7800000>; + hisilicon,mtcmos-acpu-on-base = <0xf65a0000>; + + mtcmos1: regulator@a1{ + regulator-name = "G3D_PD_VDD"; + regulator-compatible = "mtcmos1"; + hisilicon,ctrl-regs = <0x830 0x834 0x83c>; + hisilicon,ctrl-data = <1 0x1>; + }; + mtcmos2: regulator@a2{ + regulator-name = "SOC_MED"; + regulator-compatible = "mtcmos2"; + hisilicon,ctrl-regs = <0x830 0x834 0x83c>; + hisilicon,ctrl-data = <2 0x1>; + }; + };