| Message ID | 1446730488-31930-2-git-send-email-puck.chen@hisilicon.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Nov 05, 2015 at 09:34:42PM +0800, Chen Feng wrote: Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches. > +- #interrupt-cells: Should be 2, two cells are needed for irq. > +- interrupt-controller: hi655x has internal IRQs (has own IRQ domain). > +- pmu_irq_gpio: should be &gpio_pmu_irq_n, is the IRQ gpio of hi655x. I'm not entirely sure what this is but it sounds worrying - why can you not just use a normal interrupt specifier? It also doesn't correspond to the example: > +Example: > + pmic: pmic@f8000000 { > + compatible = "hisilicon,hi655x-pmic-driver"; > + reg = <0x0 0xf8000000 0x0 0x1000>; > + #interrupt-cells = <2>; > + interrupt-controller; > + pmic_gpios = <&gpio_pmu_irq_n>; > + status = "okay"; > + } > -- > 1.9.1 > >
diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt new file mode 100644 index 0000000..afa2fa5 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt @@ -0,0 +1,18 @@ +Hisilicon hi655x Power Management Integrated Circuit (PMIC) + +Required properties: +- compatible: Should be "hisilicon,hi655x-pmic-driver" +- reg: Base address of PMIC on hi6220 soc +- #interrupt-cells: Should be 2, two cells are needed for irq. +- interrupt-controller: hi655x has internal IRQs (has own IRQ domain). +- pmu_irq_gpio: should be &gpio_pmu_irq_n, is the IRQ gpio of hi655x. + +Example: + pmic: pmic@f8000000 { + compatible = "hisilicon,hi655x-pmic-driver"; + reg = <0x0 0xf8000000 0x0 0x1000>; + #interrupt-cells = <2>; + interrupt-controller; + pmic_gpios = <&gpio_pmu_irq_n>; + status = "okay"; + }