diff mbox series

media: v4l2: fix uninitialized value tuner_status(CWE-457)

Message ID 20220410015854.2826-1-chinayanlei2002@163.com
State New
Headers show
Series media: v4l2: fix uninitialized value tuner_status(CWE-457) | expand

Commit Message

chinayanlei2002@163.com April 10, 2022, 1:58 a.m. UTC 
From: Yan Lei <yan_lei@dahuatech.com>

-------------------------------------------------
Declaring variable "tuner_status" without initializer.
Using uninitialized value "tuner_status" when calling "*fe_tuner_ops->get_status". 
(The function pointer resolves to "cx24113_get_status".)


Signed-off-by: Yan Lei <yan_lei@dahuatech.com>

---
 drivers/media/v4l2-core/tuner-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/media/v4l2-core/tuner-core.c b/drivers/media/v4l2-core/tuner-core.c
index ad9224a18853..2d47c10de062 100644
--- a/drivers/media/v4l2-core/tuner-core.c
+++ b/drivers/media/v4l2-core/tuner-core.c
@@ -1118,7 +1118,7 @@  static void tuner_status(struct dvb_frontend *fe)
 	if (t->mode != V4L2_TUNER_RADIO)
 		return;
 	if (fe_tuner_ops->get_status) {
-		u32 tuner_status;
+		u32 tuner_status = 0;
 
 		fe_tuner_ops->get_status(&t->fe, &tuner_status);
 		if (tuner_status & TUNER_STATUS_LOCKED)
@@ -1258,7 +1258,7 @@  static int tuner_g_tuner(struct v4l2_subdev *sd, struct v4l2_tuner *vt)
 	if (vt->type == t->mode) {
 		vt->rxsubchans = V4L2_TUNER_SUB_MONO | V4L2_TUNER_SUB_STEREO;
 		if (fe_tuner_ops->get_status) {
-			u32 tuner_status;
+			u32 tuner_status = 0;
 
 			fe_tuner_ops->get_status(&t->fe, &tuner_status);
 			vt->rxsubchans =