| Message ID | 1446562848-15069-1-git-send-email-stuart.haslam@linaro.org |
|---|---|
| State | Accepted |
| Commit | ea70278ba9733e55a64738c1bcb21cab77613b64 |
| Headers | show |
On 11/04/2015 20:18, Nicolas Morey-Chaisemartin wrote: > Just noticed that this is the reason why pcap test is failing on my station. > Spent the last 30 minutes trying to figure out what my patch broke :) > > Maxim, could you get this to get validation to pass again ? Yes, I find that bug building with clang and then run tests. With gcc everything was right. In CI we build with clang but do not run. We will add that test case. Maxim. > > On 11/03/2015 04:00 PM, Stuart Haslam wrote: >> A call to odp_queue_param_init() is missing so uninitialized parameters >> are passed to odp_queue_create() leading to unpredictable results. >> >> Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org> >> --- >> pktio tests fail fairly regularly when built with clang. >> >> test/validation/pktio/pktio.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c >> index 9c16e94..a2da47b 100644 >> --- a/test/validation/pktio/pktio.c >> +++ b/test/validation/pktio/pktio.c >> @@ -278,6 +278,7 @@ static int create_inq(odp_pktio_t pktio, odp_queue_type_t qtype) >> odp_queue_t inq_def; >> char inq_name[ODP_QUEUE_NAME_LEN]; >> >> + odp_queue_param_init(&qparam); >> qparam.sched.prio = ODP_SCHED_PRIO_DEFAULT; >> qparam.sched.sync = ODP_SCHED_SYNC_ATOMIC; >> qparam.sched.group = ODP_SCHED_GROUP_ALL;
Merged, Maxim. On 11/04/2015 20:18, Nicolas Morey-Chaisemartin wrote: > Just noticed that this is the reason why pcap test is failing on my station. > Spent the last 30 minutes trying to figure out what my patch broke :) > > Maxim, could you get this to get validation to pass again ? > > On 11/03/2015 04:00 PM, Stuart Haslam wrote: >> A call to odp_queue_param_init() is missing so uninitialized parameters >> are passed to odp_queue_create() leading to unpredictable results. >> >> Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org> >> --- >> pktio tests fail fairly regularly when built with clang. >> >> test/validation/pktio/pktio.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c >> index 9c16e94..a2da47b 100644 >> --- a/test/validation/pktio/pktio.c >> +++ b/test/validation/pktio/pktio.c >> @@ -278,6 +278,7 @@ static int create_inq(odp_pktio_t pktio, odp_queue_type_t qtype) >> odp_queue_t inq_def; >> char inq_name[ODP_QUEUE_NAME_LEN]; >> >> + odp_queue_param_init(&qparam); >> qparam.sched.prio = ODP_SCHED_PRIO_DEFAULT; >> qparam.sched.sync = ODP_SCHED_SYNC_ATOMIC; >> qparam.sched.group = ODP_SCHED_GROUP_ALL;
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index 9c16e94..a2da47b 100644 --- a/test/validation/pktio/pktio.c +++ b/test/validation/pktio/pktio.c @@ -278,6 +278,7 @@ static int create_inq(odp_pktio_t pktio, odp_queue_type_t qtype) odp_queue_t inq_def; char inq_name[ODP_QUEUE_NAME_LEN]; + odp_queue_param_init(&qparam); qparam.sched.prio = ODP_SCHED_PRIO_DEFAULT; qparam.sched.sync = ODP_SCHED_SYNC_ATOMIC; qparam.sched.group = ODP_SCHED_GROUP_ALL;
A call to odp_queue_param_init() is missing so uninitialized parameters are passed to odp_queue_create() leading to unpredictable results. Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org> --- pktio tests fail fairly regularly when built with clang. test/validation/pktio/pktio.c | 1 + 1 file changed, 1 insertion(+)