| Message ID | 20220402192859.154977-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 2a80a66f68e37ce19dee7fdb3d3e946859712b53 |
| Headers | show |
| Series | None | expand |
On Sat, 2 Apr 2022 21:28:59 +0200, Krzysztof Kozlowski wrote: > Using node paths to extend or override a device tree node is error > prone. If there was a typo error, a new node will be created instead of > extending the existing node. This will lead to run-time errors that > could be hard to detect. > > A mistyped label on the other hand, will cause a dtc compile error > (during build time). This also reduces the indentation making the code > easier to read. > > [...] Applied, thanks! [2/2] arm64: dts: qcom: msm8996: override nodes by label commit: 2a80a66f68e37ce19dee7fdb3d3e946859712b53 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/msm8996-mtp.dts b/arch/arm64/boot/dts/qcom/msm8996-mtp.dts index 6a1699a96c99..596ad4c896f5 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-mtp.dts +++ b/arch/arm64/boot/dts/qcom/msm8996-mtp.dts @@ -18,12 +18,10 @@ aliases { chosen { stdout-path = "serial0"; }; +}; - soc { - serial@75b0000 { - status = "okay"; - }; - }; +&blsp2_uart2 { + status = "okay"; }; &hdmi {
Using node paths to extend or override a device tree node is error prone. If there was a typo error, a new node will be created instead of extending the existing node. This will lead to run-time errors that could be hard to detect. A mistyped label on the other hand, will cause a dtc compile error (during build time). This also reduces the indentation making the code easier to read. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/msm8996-mtp.dts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)