diff mbox

m4: valgrind fix confgure output

Message ID 1445615703-29251-1-git-send-email-mike.holmes@linaro.org
State Accepted
Commit c8f1986c5ac2f67510196389600bda1dbfedb430
Headers show

Commit Message

Mike Holmes Oct. 23, 2015, 3:55 p.m. UTC
Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 m4/ax_valgrind_check.m4 | 2 --
 1 file changed, 2 deletions(-)

Comments

Anders Roxell Oct. 26, 2015, 8:04 p.m. UTC | #1
On 23 October 2015 at 17:55, Mike Holmes <mike.holmes@linaro.org> wrote:
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>

Reviewed-by: Anders Roxell <anders.roxell@linaro.org>

These changes makes sense, have this been sent upstream [1]?

Cheers,
Anders
[1] http://git.savannah.gnu.org/r/autoconf-archive.git

> ---
>  m4/ax_valgrind_check.m4 | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/m4/ax_valgrind_check.m4 b/m4/ax_valgrind_check.m4
> index ff05f56..ccee86b 100644
> --- a/m4/ax_valgrind_check.m4
> +++ b/m4/ax_valgrind_check.m4
> @@ -59,7 +59,6 @@
>
>  AC_DEFUN([AX_VALGRIND_CHECK],[
>         dnl Check for --enable-valgrind
> -       AC_MSG_CHECKING([whether to enable Valgrind on the unit tests])
>         AC_ARG_ENABLE([valgrind],
>                       [AS_HELP_STRING([--enable-valgrind], [Whether to enable Valgrind on the unit tests])],
>                       [enable_valgrind=$enableval],[enable_valgrind=])
> @@ -74,7 +73,6 @@ AC_DEFUN([AX_VALGRIND_CHECK],[
>
>         AM_CONDITIONAL([VALGRIND_ENABLED],[test "$enable_valgrind" = "yes"])
>         AC_SUBST([VALGRIND_ENABLED],[$enable_valgrind])
> -       AC_MSG_RESULT([$enable_valgrind])
>
>         # Check for Valgrind tools we care about.
>         m4_define([valgrind_tool_list],[[memcheck], [helgrind], [drd], [exp-sgcheck]])
> --
> 2.5.0
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
Mike Holmes Oct. 26, 2015, 8:12 p.m. UTC | #2
On 26 October 2015 at 16:04, Anders Roxell <anders.roxell@linaro.org> wrote:

> On 23 October 2015 at 17:55, Mike Holmes <mike.holmes@linaro.org> wrote:

> > Signed-off-by: Mike Holmes <mike.holmes@linaro.org>

>

> Reviewed-by: Anders Roxell <anders.roxell@linaro.org>

>

> These changes makes sense, have this been sent upstream [1]?

>


In the process of sending them


>

> Cheers,

> Anders

> [1] http://git.savannah.gnu.org/r/autoconf-archive.git

>

> > ---

> >  m4/ax_valgrind_check.m4 | 2 --

> >  1 file changed, 2 deletions(-)

> >

> > diff --git a/m4/ax_valgrind_check.m4 b/m4/ax_valgrind_check.m4

> > index ff05f56..ccee86b 100644

> > --- a/m4/ax_valgrind_check.m4

> > +++ b/m4/ax_valgrind_check.m4

> > @@ -59,7 +59,6 @@

> >

> >  AC_DEFUN([AX_VALGRIND_CHECK],[

> >         dnl Check for --enable-valgrind

> > -       AC_MSG_CHECKING([whether to enable Valgrind on the unit tests])

> >         AC_ARG_ENABLE([valgrind],

> >                       [AS_HELP_STRING([--enable-valgrind], [Whether to

> enable Valgrind on the unit tests])],

> >                       [enable_valgrind=$enableval],[enable_valgrind=])

> > @@ -74,7 +73,6 @@ AC_DEFUN([AX_VALGRIND_CHECK],[

> >

> >         AM_CONDITIONAL([VALGRIND_ENABLED],[test "$enable_valgrind" =

> "yes"])

> >         AC_SUBST([VALGRIND_ENABLED],[$enable_valgrind])

> > -       AC_MSG_RESULT([$enable_valgrind])

> >

> >         # Check for Valgrind tools we care about.

> >         m4_define([valgrind_tool_list],[[memcheck], [helgrind], [drd],

> [exp-sgcheck]])

> > --

> > 2.5.0

> >

> > _______________________________________________

> > lng-odp mailing list

> > lng-odp@lists.linaro.org

> > https://lists.linaro.org/mailman/listinfo/lng-odp

>




-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
Maxim Uvarov Oct. 27, 2015, 8:56 a.m. UTC | #3
Merged,
Maxim.

On 10/26/2015 23:04, Anders Roxell wrote:
> On 23 October 2015 at 17:55, Mike Holmes <mike.holmes@linaro.org> wrote:
>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> Reviewed-by: Anders Roxell <anders.roxell@linaro.org>
>
> These changes makes sense, have this been sent upstream [1]?
>
> Cheers,
> Anders
> [1] http://git.savannah.gnu.org/r/autoconf-archive.git
>
>> ---
>>   m4/ax_valgrind_check.m4 | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/m4/ax_valgrind_check.m4 b/m4/ax_valgrind_check.m4
>> index ff05f56..ccee86b 100644
>> --- a/m4/ax_valgrind_check.m4
>> +++ b/m4/ax_valgrind_check.m4
>> @@ -59,7 +59,6 @@
>>
>>   AC_DEFUN([AX_VALGRIND_CHECK],[
>>          dnl Check for --enable-valgrind
>> -       AC_MSG_CHECKING([whether to enable Valgrind on the unit tests])
>>          AC_ARG_ENABLE([valgrind],
>>                        [AS_HELP_STRING([--enable-valgrind], [Whether to enable Valgrind on the unit tests])],
>>                        [enable_valgrind=$enableval],[enable_valgrind=])
>> @@ -74,7 +73,6 @@ AC_DEFUN([AX_VALGRIND_CHECK],[
>>
>>          AM_CONDITIONAL([VALGRIND_ENABLED],[test "$enable_valgrind" = "yes"])
>>          AC_SUBST([VALGRIND_ENABLED],[$enable_valgrind])
>> -       AC_MSG_RESULT([$enable_valgrind])
>>
>>          # Check for Valgrind tools we care about.
>>          m4_define([valgrind_tool_list],[[memcheck], [helgrind], [drd], [exp-sgcheck]])
>> --
>> 2.5.0
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/lng-odp
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/m4/ax_valgrind_check.m4 b/m4/ax_valgrind_check.m4
index ff05f56..ccee86b 100644
--- a/m4/ax_valgrind_check.m4
+++ b/m4/ax_valgrind_check.m4
@@ -59,7 +59,6 @@ 
 
 AC_DEFUN([AX_VALGRIND_CHECK],[
 	dnl Check for --enable-valgrind
-	AC_MSG_CHECKING([whether to enable Valgrind on the unit tests])
 	AC_ARG_ENABLE([valgrind],
 	              [AS_HELP_STRING([--enable-valgrind], [Whether to enable Valgrind on the unit tests])],
 	              [enable_valgrind=$enableval],[enable_valgrind=])
@@ -74,7 +73,6 @@  AC_DEFUN([AX_VALGRIND_CHECK],[
 
 	AM_CONDITIONAL([VALGRIND_ENABLED],[test "$enable_valgrind" = "yes"])
 	AC_SUBST([VALGRIND_ENABLED],[$enable_valgrind])
-	AC_MSG_RESULT([$enable_valgrind])
 
 	# Check for Valgrind tools we care about.
 	m4_define([valgrind_tool_list],[[memcheck], [helgrind], [drd], [exp-sgcheck]])