diff mbox series

Bluetooth: mt7921s: fix a NULL check

Message ID 20220323074830.GA4639@kili
State New
Headers show
Series Bluetooth: mt7921s: fix a NULL check | expand

Commit Message

Dan Carpenter March 23, 2022, 7:48 a.m. UTC 
There is a typo in the NULL check so it's never true.  It should be
checking "*ven_data" instead of "ven_data".

Fixes: 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/bluetooth/btmtksdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dan Carpenter March 23, 2022, 9:18 a.m. UTC | #1 
On Wed, Mar 23, 2022 at 01:49:26AM -0700, bluez.test.bot@gmail.com wrote:
> This is an automated email and please do not reply to this email.
> 
> Dear Submitter,
> 
> Thank you for submitting the patches to the linux bluetooth mailing list.
> While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.
> 
> ----- Output -----
> error: patch failed: drivers/bluetooth/btmtksdio.c:961
> error: drivers/bluetooth/btmtksdio.c: patch does not apply
> hint: Use 'git am --show-current-patch' to see the failed patch
> 
> 
> Please resolve the issue and submit the patches again.

I tested it and it applies to:

git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master

It would help if the email said what tree the build-bot is using.  Who
is maintaining the build-bot?

regards,
dan carpenter
diff mbox series

Patch

diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index f3dc5881fff7..b6d77e04240c 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -961,7 +961,7 @@  static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
 	}
 
 	*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
-	if (!ven_data) {
+	if (!*ven_data) {
 		err = -ENOMEM;
 		goto error;
 	}