diff mbox series

Input: adi: remove redundant variable z

Message ID 20220318002318.80519-1-colin.i.king@gmail.com
State Accepted
Commit a949087c2285c8de4f0f204cab2d4eece9d929a2
Headers show
Series Input: adi: remove redundant variable z | expand

Commit Message

Colin Ian King March 18, 2022, 12:23 a.m. UTC
Variable z is being assigned a value that is never read, the
variable is redundant and can be removed.

Cleans up clang scan build warning:
drivers/input/joystick/adi.c:139:6: warning: Although the
value stored to 'z' is used in the enclosing expression,
the value is never actually read from 'z' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/input/joystick/adi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dmitry Torokhov March 21, 2022, 5:04 a.m. UTC | #1
On Fri, Mar 18, 2022 at 12:23:18AM +0000, Colin Ian King wrote:
> Variable z is being assigned a value that is never read, the
> variable is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> drivers/input/joystick/adi.c:139:6: warning: Although the
> value stored to 'z' is used in the enclosing expression,
> the value is never actually read from 'z' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/input/joystick/adi.c b/drivers/input/joystick/adi.c
index 592c95b87f54..e10d57bf1180 100644
--- a/drivers/input/joystick/adi.c
+++ b/drivers/input/joystick/adi.c
@@ -123,7 +123,7 @@  static void adi_read_packet(struct adi_port *port)
 {
 	struct adi *adi = port->adi;
 	struct gameport *gameport = port->gameport;
-	unsigned char u, v, w, x, z;
+	unsigned char u, v, w, x;
 	int t[2], s[2], i;
 	unsigned long flags;
 
@@ -136,7 +136,7 @@  static void adi_read_packet(struct adi_port *port)
 	local_irq_save(flags);
 
 	gameport_trigger(gameport);
-	v = z = gameport_read(gameport);
+	v = gameport_read(gameport);
 
 	do {
 		u = v;