diff mbox

[PULL,05/49] exec.c: Don't call cpu_reload_memory_map() from cpu_exec_init()

Message ID 1444985411-17803-6-git-send-email-pbonzini@redhat.com
State Accepted
Commit 0a1c71cec63e95f9b8d0dc96d049d2daa00c5210
Headers show

Commit Message

Paolo Bonzini Oct. 16, 2015, 8:49 a.m. UTC 
From: Peter Maydell <peter.maydell@linaro.org>

Currently we call cpu_reload_memory_map() from cpu_exec_init(),
but this is not necessary:
 * KVM doesn't use the data structures maintained by
   cpu_reload_memory_map() (the TLB and cpu->memory_dispatch)
 * for TCG, we will call this function via tcg_commit() either
   as soon as tcg_cpu_address_space_init() registers the listener,
   or when the first MemoryRegion is added to the AddressSpace
   if the AS is empty when we register the listener

The unnecessary call is awkward for adding support for multiple
address spaces per CPU, so drop it.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Message-Id: <1443709790-25180-2-git-send-email-peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 exec.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox

Patch

diff --git a/exec.c b/exec.c
index 7d90a52..ab5d8a8 100644
--- a/exec.c
+++ b/exec.c
@@ -601,7 +601,6 @@  void cpu_exec_init(CPUState *cpu, Error **errp)
 #ifndef CONFIG_USER_ONLY
     cpu->as = &address_space_memory;
     cpu->thread_id = qemu_get_thread_id();
-    cpu_reload_memory_map(cpu);
 #endif
 
 #if defined(CONFIG_USER_ONLY)