| Message ID | 20220308002747.122682-8-michael.christie@oracle.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | misc iscsi patches | expand |
On 2022/3/8 8:27, Mike Christie wrote: > For software iscsi, we do a session per host so there is no need to set > the target's can_queue since its the same as the host one. It just results > in extra atomic checks in the main IO path. > > Signed-off-by: Mike Christie <michael.christie@oracle.com> > --- > drivers/scsi/iscsi_tcp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c > index 3bdefc4b6b17..974245eab605 100644 > --- a/drivers/scsi/iscsi_tcp.c > +++ b/drivers/scsi/iscsi_tcp.c > @@ -1053,7 +1053,6 @@ static struct scsi_host_template iscsi_sw_tcp_sht = { > .eh_target_reset_handler = iscsi_eh_recover_target, > .dma_boundary = PAGE_SIZE - 1, > .slave_configure = iscsi_sw_tcp_slave_configure, > - .target_alloc = iscsi_target_alloc, > .proc_name = "iscsi_tcp", > .this_id = -1, > .track_queue_depth = 1, > Reviewed-by: Wu Bo <wubo40@huawei.com> .
On 3/7/22 16:27, Mike Christie wrote: > For software iscsi, we do a session per host so there is no need to set > the target's can_queue since its the same as the host one. It just results > in extra atomic checks in the main IO path. > > Signed-off-by: Mike Christie <michael.christie@oracle.com> > --- > drivers/scsi/iscsi_tcp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c > index 3bdefc4b6b17..974245eab605 100644 > --- a/drivers/scsi/iscsi_tcp.c > +++ b/drivers/scsi/iscsi_tcp.c > @@ -1053,7 +1053,6 @@ static struct scsi_host_template iscsi_sw_tcp_sht = { > .eh_target_reset_handler = iscsi_eh_recover_target, > .dma_boundary = PAGE_SIZE - 1, > .slave_configure = iscsi_sw_tcp_slave_configure, > - .target_alloc = iscsi_target_alloc, > .proc_name = "iscsi_tcp", > .this_id = -1, > .track_queue_depth = 1, Reviewed-by: Lee Duncan <lduncan@suse.com>
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c index 3bdefc4b6b17..974245eab605 100644 --- a/drivers/scsi/iscsi_tcp.c +++ b/drivers/scsi/iscsi_tcp.c @@ -1053,7 +1053,6 @@ static struct scsi_host_template iscsi_sw_tcp_sht = { .eh_target_reset_handler = iscsi_eh_recover_target, .dma_boundary = PAGE_SIZE - 1, .slave_configure = iscsi_sw_tcp_slave_configure, - .target_alloc = iscsi_target_alloc, .proc_name = "iscsi_tcp", .this_id = -1, .track_queue_depth = 1,
For software iscsi, we do a session per host so there is no need to set the target's can_queue since its the same as the host one. It just results in extra atomic checks in the main IO path. Signed-off-by: Mike Christie <michael.christie@oracle.com> --- drivers/scsi/iscsi_tcp.c | 1 - 1 file changed, 1 deletion(-)