| Message ID | 20220308023325.31702-1-linmq006@gmail.com |
|---|---|
| State | Accepted |
| Commit | 5575f7f49134c7386a684335c9007737c606d3b5 |
| Headers | show |
| Series | ASoC: SOF: Add missing of_node_put() in imx8m_probe | expand |
On 08/03/2022 04:33, Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. Reviewed-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> > Fixes: afb93d716533 ("ASoC: SOF: imx: Add i.MX8M HW support") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > sound/soc/sof/imx/imx8m.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/sof/imx/imx8m.c b/sound/soc/sof/imx/imx8m.c > index 788e77bcb603..60251486b24b 100644 > --- a/sound/soc/sof/imx/imx8m.c > +++ b/sound/soc/sof/imx/imx8m.c > @@ -224,6 +224,7 @@ static int imx8m_probe(struct snd_sof_dev *sdev) > } > > ret = of_address_to_resource(res_node, 0, &res); > + of_node_put(res_node); > if (ret) { > dev_err(&pdev->dev, "failed to get reserved region address\n"); > goto exit_pdev_unregister;
diff --git a/sound/soc/sof/imx/imx8m.c b/sound/soc/sof/imx/imx8m.c index 788e77bcb603..60251486b24b 100644 --- a/sound/soc/sof/imx/imx8m.c +++ b/sound/soc/sof/imx/imx8m.c @@ -224,6 +224,7 @@ static int imx8m_probe(struct snd_sof_dev *sdev) } ret = of_address_to_resource(res_node, 0, &res); + of_node_put(res_node); if (ret) { dev_err(&pdev->dev, "failed to get reserved region address\n"); goto exit_pdev_unregister;
The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. Fixes: afb93d716533 ("ASoC: SOF: imx: Add i.MX8M HW support") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- sound/soc/sof/imx/imx8m.c | 1 + 1 file changed, 1 insertion(+)